From: Jason Gunthorpe <jgg@nvidia.com>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: Yishai Hadas <yishaih@nvidia.com>,
Doug Ledford <dledford@redhat.com>, <linux-rdma@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
Leon Romanovsky <leonro@nvidia.com>
Subject: Re: [PATCH rdma-next] RDMA/mlx4: remove bogus dev_base_lock usage
Date: Thu, 10 Dec 2020 17:08:13 -0400 [thread overview]
Message-ID: <20201210210813.GA2143210@nvidia.com> (raw)
In-Reply-To: <20201208193928.1500893-1-vladimir.oltean@nxp.com>
On Tue, Dec 08, 2020 at 09:39:28PM +0200, Vladimir Oltean wrote:
> It is not clear what this lock protects. If the authors wanted to ensure
> that "dev" does not disappear, that is impossible, given the following
> code path:
>
> mlx4_ib_netdev_event (under RTNL mutex)
> -> mlx4_ib_scan_netdevs
> -> mlx4_ib_update_qps
>
> Also, the dev_base_lock does not protect dev->dev_addr either.
>
> So it serves no purpose here. Remove it.
>
> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
> drivers/infiniband/hw/mlx4/main.c | 3 ---
> 1 file changed, 3 deletions(-)
Applied to for-next, thanks
Jason
prev parent reply other threads:[~2020-12-10 21:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 19:39 [PATCH rdma-next] RDMA/mlx4: remove bogus dev_base_lock usage Vladimir Oltean
2020-12-10 21:08 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201210210813.GA2143210@nvidia.com \
--to=jgg@nvidia.com \
--cc=dledford@redhat.com \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vladimir.oltean@nxp.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).