From: Jason Gunthorpe <jgg@nvidia.com>
To: Bob Pearson <rpearsonhpe@gmail.com>
Cc: <zyjzyj2000@gmail.com>, <linux-rdma@vger.kernel.org>,
Bob Pearson <rpearson@hpe.com>
Subject: Re: [PATCH v2] RDMA/rxe: Use acquire/release for memory ordering
Date: Fri, 11 Dec 2020 19:59:16 -0400 [thread overview]
Message-ID: <20201211235916.GA2238970@nvidia.com> (raw)
In-Reply-To: <20201210174258.5234-1-rpearson@hpe.com>
On Thu, Dec 10, 2020 at 11:42:59AM -0600, Bob Pearson wrote:
> Changed work and completion queues to use smp_load_acquire() and
> smp_store_release() to synchronize between driver and users.
> This commit goes with a matching series of commits in the rxe user
> space provider.
>
> v2: Addressed same issue for kernel ULPs which use rxe_post_send/recv().
>
> Signed-off-by: Bob Pearson <rpearson@hpe.com>
> ---
> drivers/infiniband/sw/rxe/rxe_cq.c | 5 --
> drivers/infiniband/sw/rxe/rxe_queue.h | 94 +++++++++++++++++----------
> drivers/infiniband/sw/rxe/rxe_verbs.c | 11 ----
> include/uapi/rdma/rdma_user_rxe.h | 21 ++++++
> 4 files changed, 81 insertions(+), 50 deletions(-)
This really is a lot better than what was here, the extra barriers on
empty/full can be fine tuned later
So applied to for-next
Thanks,
Jason
prev parent reply other threads:[~2020-12-12 1:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 17:42 [PATCH v2] RDMA/rxe: Use acquire/release for memory ordering Bob Pearson
2020-12-10 23:14 ` Jason Gunthorpe
2020-12-11 23:59 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201211235916.GA2238970@nvidia.com \
--to=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearson@hpe.com \
--cc=rpearsonhpe@gmail.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).