[PATCH for-next 0/7] RDMA/rxe: cleanup and extensions

[PATCH for-next 0/7] RDMA/rxe: cleanup and extensions

[Bob Pearson]

This patch series makes various cleanups and extensions to the
object pool core in RDMA/rxe. They are mostly extracted from an
earlier patch set that implemented memory windows and extended
verbs APIs but are separated out since they stand on their own.

Bob Pearson (7):
  RDMA/rxe: Remove unneeded RXE_POOL_ATOMIC flag
  RDMA/rxe: Let pools support both keys and indices
  RDMA/rxe: Add elem_offset field to rxe_type_info
  RDMA/rxe: Make pool lookup and alloc APIs type safe
  RDMA/rxe: Make add/drop key/index APIs type safe
  RDMA/rxe: Add unlocked versions of pool APIs
  RDMA/rxe: Fix race in rxe_mcast.c

 drivers/infiniband/sw/rxe/rxe_mcast.c |  64 +++++---
 drivers/infiniband/sw/rxe/rxe_pool.c  | 226 +++++++++++++++++---------
 drivers/infiniband/sw/rxe/rxe_pool.h  |  94 ++++++++---
 drivers/infiniband/sw/rxe/rxe_verbs.c |  16 +-
 4 files changed, 268 insertions(+), 132 deletions(-)

-- 
2.27.0

Re: [PATCH for-next 0/7] RDMA/rxe: cleanup and extensions

[Leon Romanovsky]

On Mon, Dec 14, 2020 at 05:49:12PM -0600, Bob Pearson wrote:
> This patch series makes various cleanups and extensions to the
> object pool core in RDMA/rxe. They are mostly extracted from an
> earlier patch set that implemented memory windows and extended
> verbs APIs but are separated out since they stand on their own.
>
> Bob Pearson (7):
>   RDMA/rxe: Remove unneeded RXE_POOL_ATOMIC flag
>   RDMA/rxe: Let pools support both keys and indices
>   RDMA/rxe: Add elem_offset field to rxe_type_info
>   RDMA/rxe: Make pool lookup and alloc APIs type safe
>   RDMA/rxe: Make add/drop key/index APIs type safe
>   RDMA/rxe: Add unlocked versions of pool APIs
>   RDMA/rxe: Fix race in rxe_mcast.c

I don't see the patches in the ML.
https://lore.kernel.org/linux-rdma/20201214234919.4639-1-rpearson@hpe.com/
Did you send them?

Thanks

[PATCH for-next 0/7] RDMA/rxe: cleanup and extensions

[Bob Pearson]

This patch series makes various cleanups and extensions to the
object pool core in RDMA/rxe. They are mostly extracted from an
earlier patch set that implemented memory windows and extended
verbs APIs but are separated out since they stand on their own.

Bob Pearson (7):
  RDMA/rxe: Remove unneeded RXE_POOL_ATOMIC flag
  RDMA/rxe: Let pools support both keys and indices
  RDMA/rxe: Add elem_offset field to rxe_type_info
  RDMA/rxe: Make pool lookup and alloc APIs type safe
  RDMA/rxe: Make add/drop key/index APIs type safe
  RDMA/rxe: Add unlocked versions of pool APIs
  RDMA/rxe: Fix race in rxe_mcast.c

 drivers/infiniband/sw/rxe/rxe_mcast.c |  64 +++++---
 drivers/infiniband/sw/rxe/rxe_pool.c  | 226 +++++++++++++++++---------
 drivers/infiniband/sw/rxe/rxe_pool.h  |  94 ++++++++---
 drivers/infiniband/sw/rxe/rxe_verbs.c |  16 +-
 4 files changed, 268 insertions(+), 132 deletions(-)

-- 
2.27.0

Re: [PATCH for-next 0/7] RDMA/rxe: cleanup and extensions

[Jason Gunthorpe]

On Wed, Dec 16, 2020 at 05:15:43PM -0600, Bob Pearson wrote:
> This patch series makes various cleanups and extensions to the
> object pool core in RDMA/rxe. They are mostly extracted from an
> earlier patch set that implemented memory windows and extended
> verbs APIs but are separated out since they stand on their own.
> 
> Bob Pearson (7):
>   RDMA/rxe: Remove unneeded RXE_POOL_ATOMIC flag
>   RDMA/rxe: Let pools support both keys and indices
>   RDMA/rxe: Add elem_offset field to rxe_type_info
>   RDMA/rxe: Make pool lookup and alloc APIs type safe
>   RDMA/rxe: Make add/drop key/index APIs type safe
>   RDMA/rxe: Add unlocked versions of pool APIs
>   RDMA/rxe: Fix race in rxe_mcast.c

The bug fix is worth doing and though not ideal it is not worse than
anything else in rxe. If you want to revise things as I suggested a
followup would be fine.

Also, the pool index mode can be completely replaced with an xarry,
including the bitmap allocator thing.

So applied to for-next

Thanks,
Jason