From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE617C2BB9A for ; Tue, 15 Dec 2020 07:54:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C450223E8 for ; Tue, 15 Dec 2020 07:54:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726736AbgLOHyG (ORCPT ); Tue, 15 Dec 2020 02:54:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:34350 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726749AbgLOHyB (ORCPT ); Tue, 15 Dec 2020 02:54:01 -0500 Date: Tue, 15 Dec 2020 09:53:17 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1608018801; bh=VxdBYKynl8U9or9FSPVMqwCN8NK8dLVivfL6NwbVh3M=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=W7s8tOqAzv+7YOC1/C5QYkdXTi5Tu/p6dBWBebZ0g6O4xv10YPfqM+8oZJP44PIu6 SvhD9gS58rrfykdkD2jpORioQtMYTvhATVUX++5/8xSGemX53NbqNGiabBEYRA5BUP ekhYzIFXLf7vuVTy/uIl27GyR0rhKYZGdz2XZMUgGtOnJ7wZLofK8ROCg3B4qcfVf8 o9K3dRGDxEAU87XRZ+oukN54+jGaTXOw3CrPvvgCerrlklo7blRpNzQM8BE3KYDDUT ZXfeABI8trOpvbm50+3ZlzFf0IlbIdy6LFcwWtGPTu5EiSIvzSn41TkHKAT4TPGCFX W7wugCpr9IW/A== From: Leon Romanovsky To: Zheng Yongjun Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] infiniband: core: Delete useless kfree code Message-ID: <20201215075317.GM5005@unreal> References: <20201214134655.4991-1-zhengyongjun3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201214134655.4991-1-zhengyongjun3@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Mon, Dec 14, 2020 at 09:46:55PM +0800, Zheng Yongjun wrote: > The parameter of kfree function is NULL, so kfree code is useless, delete it. > > Signed-off-by: Zheng Yongjun > --- > drivers/infiniband/core/cma_configfs.c | 1 - > 1 file changed, 1 deletion(-) The best thing will be to delete whole "free:" section and return an error immediately. Thanks > > diff --git a/drivers/infiniband/core/cma_configfs.c b/drivers/infiniband/core/cma_configfs.c > index 7ec4af2ed87a..c6e7cd9bc25a 100644 > --- a/drivers/infiniband/core/cma_configfs.c > +++ b/drivers/infiniband/core/cma_configfs.c > @@ -235,7 +235,6 @@ static int make_cma_ports(struct cma_dev_group *cma_dev_group, > > return 0; > free: > - kfree(ports); > cma_dev_group->ports = NULL; > return err; > } > -- > 2.22.0 >