From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C31EC4361B for ; Wed, 16 Dec 2020 08:22:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 18B7F233CE for ; Wed, 16 Dec 2020 08:22:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725889AbgLPIWn (ORCPT ); Wed, 16 Dec 2020 03:22:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:40468 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725879AbgLPIWn (ORCPT ); Wed, 16 Dec 2020 03:22:43 -0500 Date: Wed, 16 Dec 2020 10:21:58 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1608106922; bh=lzLRdvujDsVQPnOGLlScU9kmGcZgVrGieBPKFTlHmc4=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=N9IGGo3W/dNKc1SoVF3lN0+bI755rYJPwLtfEkoj4BZP5AhDIbMFsH5mNrpK6COJD whI18ztp2iMmkY7mIcSGrsD+nT2oaSH5YIzr/RjJ2CPwsc1KtsP9wIC11q+GCdjXKr fW4DcgLSynf8iuFC/J/oReFbGjUhZ3odbMRBUrgT3RtF48LA7BmTKEZnHlkFV/kkyu EPefCWQ+KYK4DYdSHmU/c69UveqPLjhcy9T1H52WujjMi4sU7zl9iWUbNatiMnVPpw o3KcD3NwdxRkVVJ6XaynQ6EO17HAmAAAzuMS0J9nAnLGQSoWHimPWQQyMnGcZpTNLg IA8lto+yT7Ygg== From: Leon Romanovsky To: Xiao Yang Cc: linux-rdma@vger.kernel.org Subject: Re: [PATCH rdma-core] librdmacm: Make rdma_create_qp_ex() report proper errno Message-ID: <20201216082158.GA1060282@unreal> References: <20201216015459.78733-1-yangx.jy@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201216015459.78733-1-yangx.jy@cn.fujitsu.com> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Wed, Dec 16, 2020 at 09:54:59AM +0800, Xiao Yang wrote: > Current rdma_create_qp_ex() reports fixed ENOMEM when calling > ibv_create_qp_ex() fails, so it's hard for user to know which > actual error happens on ibv_create_qp_ex(). > > Signed-off-by: Xiao Yang > --- > librdmacm/cma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) The same change should be done for the ibv_alloc_pd() call. 635 if (!cma_dev->pd) 636 cma_dev->pd = ibv_alloc_pd(cma_dev->verbs); 637 if (!cma_dev->pd) { 638 ret = ERR(ENOMEM); 639 goto out; 640 } And please add Fixes line. Thanks