From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40E53C433DB for ; Wed, 13 Jan 2021 12:18:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE07323120 for ; Wed, 13 Jan 2021 12:18:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727391AbhAMMSb (ORCPT ); Wed, 13 Jan 2021 07:18:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:55246 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727367AbhAMMSa (ORCPT ); Wed, 13 Jan 2021 07:18:30 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id EB5D5233FB; Wed, 13 Jan 2021 12:17:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610540244; bh=CbktahbK99utKTVn4CU8vpNPvsoHlJP+PdzkQQuZyXo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VZUX+xWkE26rd4X5E0exBj6uhBww6BY61LDf4PEqR6yHFE7Yo0ebqN3DctHiFYqzf +AhqupAxlShHOhe4G9/EyjCjJ3kz3A4hvPVKCWDH09HVFJE+77h0hUkaQ1KOXF19cU y+geDLZQkwO1VkOuBiSLt5tWzZP446tom52gBjhTfxTUtlGIw9nqRcDJxIz1ixIjpV K4+LKUz1hu75x3r8pLp8PNvZh0fFU6GxCFHwfYLdbXGA74trmfQ5fYlUmn0orB9uvp P1ITV823RoZkAfMQNgBu5YY43/WV7yJ8CcI/yGgpeKxmB6qyPMtEoR5FhnPwkdULEv Pvfo56espPomQ== From: Leon Romanovsky To: Doug Ledford , Jason Gunthorpe Cc: Mark Bloch , Aharon Landau , linux-rdma@vger.kernel.org, Maor Gottlieb , Parav Pandit , Hans Petter Selasky Subject: [PATCH rdma-next 5/5] RDMA/mlx5: Fix wrong free of blue flame register on error Date: Wed, 13 Jan 2021 14:17:03 +0200 Message-Id: <20210113121703.559778-6-leon@kernel.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210113121703.559778-1-leon@kernel.org> References: <20210113121703.559778-1-leon@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org From: Mark Bloch If the allocation of the fast path blue flame register fails, the driver should free the regular blue flame register. Fixes: 16c1975f1032 ("IB/mlx5: Create profile infrastructure to add and remove stage") Reported-by: Hans Petter Selasky Signed-off-by: Mark Bloch Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c index 84309bcd67d5..427221a13fbc 100644 --- a/drivers/infiniband/hw/mlx5/main.c +++ b/drivers/infiniband/hw/mlx5/main.c @@ -4340,7 +4340,7 @@ static int mlx5_ib_stage_bfrag_init(struct mlx5_ib_dev *dev) err = mlx5_alloc_bfreg(dev->mdev, &dev->fp_bfreg, false, true); if (err) - mlx5_free_bfreg(dev->mdev, &dev->fp_bfreg); + mlx5_free_bfreg(dev->mdev, &dev->bfreg); return err; } -- 2.29.2