From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D31DC433E0 for ; Thu, 14 Jan 2021 07:30:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 098722389E for ; Thu, 14 Jan 2021 07:30:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726702AbhANHaW (ORCPT ); Thu, 14 Jan 2021 02:30:22 -0500 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:3117 "EHLO hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726127AbhANHaW (ORCPT ); Thu, 14 Jan 2021 02:30:22 -0500 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Wed, 13 Jan 2021 23:29:42 -0800 Received: from localhost (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 14 Jan 2021 07:29:41 +0000 Date: Thu, 14 Jan 2021 09:29:38 +0200 From: Leon Romanovsky To: Sagi Grimberg CC: Max Gurtovoy , , , , , Israel Rukshin Subject: Re: [PATCH 3/3] IB/isert: simplify signature cap check Message-ID: <20210114072938.GM4678@unreal> References: <20210110111903.486681-1-mgurtovoy@nvidia.com> <20210110111903.486681-3-mgurtovoy@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1610609382; bh=YiMsE+aoYYRmYjcdfpgrowDdBGbib4grlhK5MAqsI7A=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To:X-Originating-IP: X-ClientProxiedBy; b=K1KPTn0zDCwIapSFFPYabQEdzyl6odMPx/4/t7A3zgdhFQKZSSmLB+uf0UjDU6Fl5 gTePfWdHAyIXWOY7vIsOxzhMSLjof03gX+jwFUQMNNnL8o7kBGzxI9gBko8WN9y4n2 k583LYUWNcvm5TKMJNgiypZsMpPvCyqkqpGyU+lrIANAyZVBpQDG3FIYzccmegVQ+i 1igwYspHl2qttmhIAKJEeJaUu7ASHScl2r7L6HWWpkT0QmSJshyfygG93JHktYkRhx TdyRqL6N6uxUtKPY0wyHyduPRHlL37efSnxslEnvmYSmBSZ5etF3NF5NJhkkwyS5dc uyG8O3YQCDTOw== Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Wed, Jan 13, 2021 at 04:08:29PM -0800, Sagi Grimberg wrote: > > > Use if/else clause instead of "condition ? val1 : val2" to make the code > > cleaner and simpler. > > Not sure what is cleaner and simpler for a simple condition, but I don't > mind either way... Agree, probably even more cleaner variant will be: device->pi_capable = !!(ib_dev->attrs.device_cap_flags & IB_DEVICE_INTEGRITY_HANDOVER); Thanks