From: Jason Gunthorpe <jgg@nvidia.com>
To: Bryan Tan <bryantan@vmware.com>
Cc: <linux-rdma@vger.kernel.org>, <pv-drivers@vmware.com>
Subject: Re: [PATCH for-rc] RDMA/vmw_pvrdma: Fix network_hdr_type reported in WC
Date: Thu, 14 Jan 2021 13:23:59 -0400 [thread overview]
Message-ID: <20210114172359.GC316809@nvidia.com> (raw)
In-Reply-To: <1610634408-31356-1-git-send-email-bryantan@vmware.com>
On Thu, Jan 14, 2021 at 06:26:48AM -0800, Bryan Tan wrote:
> The PVRDMA device defines network_hdr_type according to an old
> definition of the rdma_network_type enum that has since changed,
> resulting in the wrong rdma_network_type being reported. Fix this by
> explicitly defining the enum used by the PVRDMA device and adding a
> function to convert the pvrdma_network_type to rdma_network_type enum.
How come I can't find anything reading this in rdma-core?
$ ~/oss/rdma-core#git grep network_hdr_type
kernel-headers/rdma/vmw_pvrdma-abi.h: __u8 network_hdr_type;
??
> Fixes: 1c15b4f2a42f ("RDMA/core: Modify enum ib_gid_type and enum rdma_network_type")
> Signed-off-by: Bryan Tan <bryantan@vmware.com>
Add Cc: stable@vger.kernel.org # 5.10+
> diff --git a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_dev_api.h b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_dev_api.h
> index 86a6c054ea26..637d33944f95 100644
> --- a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_dev_api.h
> +++ b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_dev_api.h
> @@ -201,6 +201,13 @@ enum pvrdma_device_mode {
> PVRDMA_DEVICE_MODE_IB, /* InfiniBand. */
> };
>
> +enum pvrdma_network_type {
> + PVRDMA_NETWORK_IB,
> + PVRDMA_NETWORK_ROCE_V1 = PVRDMA_NETWORK_IB,
> + PVRDMA_NETWORK_IPV4,
> + PVRDMA_NETWORK_IPV6
> +};
This is in the wrong place, uapi data needs to be in
includ/ulp/rdma/vmw_pvrdma-abi.h
Jason
next prev parent reply other threads:[~2021-01-14 17:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 14:26 [PATCH for-rc] RDMA/vmw_pvrdma: Fix network_hdr_type reported in WC Bryan Tan
2021-01-14 17:23 ` Jason Gunthorpe [this message]
2021-01-15 4:58 ` Bryan Tan
2021-01-15 12:50 ` Jason Gunthorpe
2021-01-18 11:46 ` Bryan Tan
2021-01-18 13:57 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210114172359.GC316809@nvidia.com \
--to=jgg@nvidia.com \
--cc=bryantan@vmware.com \
--cc=linux-rdma@vger.kernel.org \
--cc=pv-drivers@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox