From: Jason Gunthorpe <jgg@nvidia.com>
To: "Mohamed._. Heib" <goody698@gmail.com>
Cc: Zhu Yanjun <zyjzyj2000@gmail.com>, <mwilck@suse.com>,
RDMA mailing list <linux-rdma@vger.kernel.org>,
Vijay Immanuel <vijayi@attalasystems.com>,
Nicolas Morey-Chaisemartin <nmoreychaisemartin@suse.com>
Subject: Re: [PATCH] Revert "RDMA/rxe: Remove VLAN code leftovers from RXE"
Date: Tue, 19 Jan 2021 09:01:02 -0400 [thread overview]
Message-ID: <20210119130102.GO4147@nvidia.com> (raw)
In-Reply-To: <CANRB76_kkvfX9Us0rSynaNxYuVdYT-SLxEmhp+ijSeP+++HGdA@mail.gmail.com>
On Tue, Jan 19, 2021 at 02:40:52PM +0200, Mohamed._. Heib wrote:
> Hi,
> As far as i remember the traffic still can be encapsulated over the
> vlan interface with vlan tag
> by specifying the vlan interface gid index that mapped to the vlan ip
> on the vlan parent interface gids table.
> And by removing the vlan related functionality on rxe (commit:
> b2d2440430c0) the rxe still can send traffic via vlan interface
> but can't receive from vlan interface and that will break the vlan
> functionality on rxe so i think you need keep the vlan related code on
> rxe.
That may be, but the code here is still wrong.
Incoming packets are supposed to be matched to the gid table, which
specifies the allowed vlans, it can't just be taken raw from the skb
like this.
If someone wants to add vlan support to rxe it needs to be done right,
currently it doesn't support vlan.
Jason
next prev parent reply other threads:[~2021-01-19 13:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 10:56 [PATCH] Revert "RDMA/rxe: Remove VLAN code leftovers from RXE" mwilck
2021-01-19 12:10 ` Zhu Yanjun
[not found] ` <CANRB76_kkvfX9Us0rSynaNxYuVdYT-SLxEmhp+ijSeP+++HGdA@mail.gmail.com>
2021-01-19 13:01 ` Jason Gunthorpe [this message]
2021-01-19 13:49 ` Martin Wilck
2021-01-19 13:13 ` Martin Wilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210119130102.GO4147@nvidia.com \
--to=jgg@nvidia.com \
--cc=goody698@gmail.com \
--cc=linux-rdma@vger.kernel.org \
--cc=mwilck@suse.com \
--cc=nmoreychaisemartin@suse.com \
--cc=vijayi@attalasystems.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox