From: Leon Romanovsky <leon@kernel.org>
To: Gal Pressman <galpress@amazon.com>
Cc: Jason Gunthorpe <jgg@nvidia.com>,
Doug Ledford <dledford@redhat.com>,
linux-rdma@vger.kernel.org,
Alexander Matushevsky <matua@amazon.com>,
"Leybovich, Yossi" <sleybo@amazon.com>
Subject: Re: [PATCH for-next 0/2] Host information userspace version
Date: Tue, 19 Jan 2021 15:34:58 +0200 [thread overview]
Message-ID: <20210119133458.GK21258@unreal> (raw)
In-Reply-To: <1cb7058a-0bde-943b-64b7-d2a39337a085@amazon.com>
On Tue, Jan 19, 2021 at 03:19:15PM +0200, Gal Pressman wrote:
> On 19/01/2021 13:58, Leon Romanovsky wrote:
> > On Tue, Jan 19, 2021 at 11:10:59AM +0200, Gal Pressman wrote:
> >> On 19/01/2021 10:46, Leon Romanovsky wrote:
> >>> On Tue, Jan 19, 2021 at 09:17:14AM +0200, Gal Pressman wrote:
> >>>> On 05/01/2021 12:43, Gal Pressman wrote:
> >>>>> The following two patches add the userspace version to the host
> >>>>> information struct reported to the device, used for debugging and
> >>>>> troubleshooting purposes.
> >>>>>
> >>>>> PR was sent:
> >>>>> https://github.com/linux-rdma/rdma-core/pull/918
> >>>>>
> >>>>> Thanks,
> >>>>> Gal
> >>>>
> >>>> Anything stopping this series from being merged?
> >>>
> >>> It is unclear when this forwarding of non-verbs data to the FW will stop.
> >>
> >> This was already discussed in the PR. Not everything should be passed through
> >> this interface, there should be a limit and it should be examined per case.
> >> rdma-core version is clearly related to an RDMA device.
> >
> > "Clearly or not" - it depends on the observer.
> >
> >>
> >> BTW, if you have any concerns about a patch you can state them, you don't have
> >> to ignore it and wait for the submitter to ask what's wrong..
> >
> > Didn't you mistake me with anyone else?
>
> No, you decided to answer my original question :).
>
> > I'm reviewer in the kernel exactly like you and it gives me nice thing - ignore patches.
>
> Don't get me wrong, your review is very appreciated, but this series is 20 LOC
> which you already reviewed two weeks ago, and I replied to all comments.
> Ignoring patches is fine, but please don't review, ignore and wait for the last
> minute to say they shouldn't be merged.
Sorry, but it is impossible to get it right.
I gave you hint WHY it takes so long, it is not review/ack/nack or
anything like this.
Thanks
next prev parent reply other threads:[~2021-01-19 18:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 10:43 [PATCH for-next 0/2] Host information userspace version Gal Pressman
2021-01-05 10:43 ` [PATCH for-next 1/2] RDMA/efa: Move host info set to first ucontext allocation Gal Pressman
2021-01-05 11:21 ` Leon Romanovsky
2021-01-05 12:22 ` Gal Pressman
2021-01-05 12:40 ` Leon Romanovsky
2021-01-05 13:39 ` Gal Pressman
2021-01-05 10:43 ` [PATCH for-next 2/2] RDMA/efa: Report userspace version in host info Gal Pressman
2021-01-19 7:17 ` [PATCH for-next 0/2] Host information userspace version Gal Pressman
2021-01-19 8:46 ` Leon Romanovsky
2021-01-19 9:10 ` Gal Pressman
2021-01-19 11:58 ` Leon Romanovsky
2021-01-19 13:19 ` Gal Pressman
2021-01-19 13:34 ` Leon Romanovsky [this message]
2021-01-21 18:35 ` Jason Gunthorpe
2021-01-21 19:40 ` Gal Pressman
2021-01-27 16:57 ` Jason Gunthorpe
2021-01-27 17:53 ` Gal Pressman
2021-02-28 9:56 ` Gal Pressman
2021-03-02 0:04 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210119133458.GK21258@unreal \
--to=leon@kernel.org \
--cc=dledford@redhat.com \
--cc=galpress@amazon.com \
--cc=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=matua@amazon.com \
--cc=sleybo@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox