From: Leon Romanovsky <leon@kernel.org>
To: Parav Pandit <parav@nvidia.com>
Cc: Jason Gunthorpe <jgg@nvidia.com>,
Doug Ledford <dledford@redhat.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Mark Bloch <mbloch@nvidia.com>
Subject: Re: [PATCH rdma-next 07/10] IB/mlx5: Return appropriate error code instead of ENOMEM
Date: Tue, 2 Feb 2021 20:57:42 +0200 [thread overview]
Message-ID: <20210202185742.GF3264866@unreal> (raw)
In-Reply-To: <BY5PR12MB43220FA2D87A12FEBA246227DCB59@BY5PR12MB4322.namprd12.prod.outlook.com>
On Tue, Feb 02, 2021 at 04:01:24PM +0000, Parav Pandit wrote:
>
>
> > From: Jason Gunthorpe <jgg@nvidia.com>
> > Sent: Tuesday, February 2, 2021 8:51 PM
> > >
> > > xa_lock(&imr->implicit_children);
> > > - /*
> > > - * Once the store to either xarray completes any error unwind has to
> > > - * use synchronize_srcu(). Avoid this with xa_reserve()
> > > - */
> >
> > It is not wrong to remove this comment, but why is it in this patch?
> >
> > Jason
>
> Hi Leon,
> Can you please check your tree, how this hunk got merged in this patch?
> In my internal gerrit submission, I do not have this hunk.
> May be somehow it got here as part of Yishai's ODP srcu patches?
This explains why I didn't find this hunk in Yishai's patch.
https://lore.kernel.org/linux-rdma/20210128064812.1921519-1-leon@kernel.org
Thanks.
next prev parent reply other threads:[~2021-02-02 19:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 15:00 [PATCH rdma-next 00/10] Various cleanups Leon Romanovsky
2021-01-27 15:00 ` [PATCH rdma-next 01/10] IB/mlx5: Move mlx5_port_caps from mlx5_core_dev to mlx5_ib_dev Leon Romanovsky
2021-01-27 15:00 ` [PATCH rdma-next 02/10] IB/mlx5: Avoid calling query device for reading pkey table length Leon Romanovsky
2021-02-01 10:19 ` Leon Romanovsky
2021-01-27 15:00 ` [PATCH rdma-next 03/10] IB/mlx5: Support default partition key for representor port Leon Romanovsky
2021-01-27 15:00 ` [PATCH rdma-next 04/10] IB/mlx5: Improve query port " Leon Romanovsky
2021-01-27 15:00 ` [PATCH rdma-next 05/10] RDMA/core: Introduce and use API to read port immutable data Leon Romanovsky
2021-02-02 16:50 ` Jason Gunthorpe
2021-02-02 18:05 ` Parav Pandit
2021-02-02 18:14 ` Jason Gunthorpe
2021-02-02 19:00 ` Parav Pandit
2021-01-27 15:00 ` [PATCH rdma-next 06/10] IB/mlx5: Use rdma_for_each_port for port iteration Leon Romanovsky
2021-01-27 15:00 ` [PATCH rdma-next 07/10] IB/mlx5: Return appropriate error code instead of ENOMEM Leon Romanovsky
2021-02-02 15:21 ` Jason Gunthorpe
2021-02-02 16:01 ` Parav Pandit
2021-02-02 18:57 ` Leon Romanovsky [this message]
2021-01-27 15:00 ` [PATCH rdma-next 08/10] IB/cm: Avoid a loop when device has 255 ports Leon Romanovsky
2021-01-27 15:00 ` [PATCH rdma-next 09/10] IB/mlx4: Use port iterator and validation APIs Leon Romanovsky
2021-01-27 15:00 ` [PATCH rdma-next 10/10] IB/core: Use valid port number to check link layer Leon Romanovsky
2021-02-02 23:35 ` [PATCH rdma-next 00/10] Various cleanups Jason Gunthorpe
2021-02-03 5:47 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210202185742.GF3264866@unreal \
--to=leon@kernel.org \
--cc=dledford@redhat.com \
--cc=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=parav@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox