From: Dan Carpenter <dan.carpenter@oracle.com>
To: Saeed Mahameed <saeedm@nvidia.com>
Cc: Roi Dayan <roid@nvidia.com>, Feras Daoud <ferasda@nvidia.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: [bug report] net/mxl5e: Add change profile method
Date: Tue, 9 Feb 2021 23:02:38 -0800 (PST) [thread overview]
Message-ID: <20210210070238.GR20820@kadam> (raw)
In-Reply-To: <82d9b9b7b0b063aaab358041906baf3ac48ec4a9.camel@nvidia.com>
On Wed, Feb 10, 2021 at 06:12:58AM +0000, Saeed Mahameed wrote:
> On Fri, 2021-02-05 at 15:45 +0300, Dan Carpenter wrote:
> > Hello Saeed Mahameed and Feras Daoud,
> >
>
> Hi Dan, thanks for the report, adding Roi the owner of this change.
>
> > I'm not exactly sure if I should blame commit c4d7eb57687f:
> > "net/mxl5e:
> > Add change profile method" fomr Mar 22, 2020 or commit 182570b26223
> > ("net/mlx5e: Gather common netdev init/cleanup functionality in one
> > place") from Oct 2, 2018.
> >
> > drivers/net/ethernet/mellanox/mlx5/core/en_main.c:5658
> > mlx5e_netdev_change_profile() warn: 'priv->htb.qos_sq_stats' double
> > freed
> > drivers/net/ethernet/mellanox/mlx5/core/en_main.c:5658
> > mlx5e_netdev_change_profile() warn: 'priv->scratchpad.cpumask' double
> > freed
> > drivers/net/ethernet/mellanox/mlx5/core/en_main.c:5789 mlx5e_probe()
> > warn: 'priv->htb.qos_sq_stats' double freed
> > drivers/net/ethernet/mellanox/mlx5/core/en_main.c:5789 mlx5e_probe()
> > warn: 'priv->scratchpad.cpumask' double freed
> > drivers/net/ethernet/mellanox/mlx5/core/en_main.c:5802 mlx5e_remove()
> > warn: 'priv->htb.qos_sq_stats' double freed
> > drivers/net/ethernet/mellanox/mlx5/core/en_main.c:5802 mlx5e_remove()
> > warn: 'priv->scratchpad.cpumask' double freed
> > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:1317
> > mlx5e_vport_rep_unload() warn: 'priv->htb.qos_sq_stats' double freed
> > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:1317
> > mlx5e_vport_rep_unload() warn: 'priv->scratchpad.cpumask' double
> > freed
>
> If I may ask,
> What is this report ? Coverity ? static checker ? or runtime checks ?
>
This is a Smatch check but you have to have the cross function database
built. And the code is from 2018 so something must have improved in how
the cross function DB is working recently for it to generate this
warning... I'm not sure exactly what I improved or if I have pushed
that change yet...
regards,
dan carpenter
prev parent reply other threads:[~2021-02-10 7:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 12:45 [bug report] net/mxl5e: Add change profile method Dan Carpenter
2021-02-10 6:12 ` Saeed Mahameed
2021-02-10 7:02 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210070238.GR20820@kadam \
--to=dan.carpenter@oracle.com \
--cc=ferasda@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=roid@nvidia.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox