From: Jason Gunthorpe <jgg@ziepe.ca>
To: Leon Romanovsky <leon@kernel.org>, Arnd Bergmann <arnd@arndb.de>
Cc: Zhu Yanjun <zyjzyj2000@gmail.com>,
Julian Braha <julianbraha@gmail.com>,
Doug Ledford <dledford@redhat.com>,
RDMA mailing list <linux-rdma@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO
Date: Mon, 22 Feb 2021 11:58:45 -0400 [thread overview]
Message-ID: <20210222155845.GI2643399@ziepe.ca> (raw)
In-Reply-To: <YDOq060TvAwLgknl@unreal>
On Mon, Feb 22, 2021 at 03:00:03PM +0200, Leon Romanovsky wrote:
> On Mon, Feb 22, 2021 at 10:39:20AM +0800, Zhu Yanjun wrote:
> > On Sun, Feb 21, 2021 at 2:49 PM Leon Romanovsky <leon@kernel.org> wrote:
> > >
> > > On Fri, Feb 19, 2021 at 06:32:26PM -0500, Julian Braha wrote:
> > > > commit 6e61907779ba99af785f5b2397a84077c289888a
> > > > Author: Julian Braha <julianbraha@gmail.com>
> > > > Date: Fri Feb 19 18:20:57 2021 -0500
> > > >
> > > > drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO
> > > >
> > > > When RDMA_RXE is enabled and CRYPTO is disabled,
> > > > Kbuild gives the following warning:
> > > >
> > > > WARNING: unmet direct dependencies detected for CRYPTO_CRC32
> > > > Depends on [n]: CRYPTO [=n]
> > > > Selected by [y]:
> > > > - RDMA_RXE [=y] && (INFINIBAND_USER_ACCESS [=y] || !INFINIBAND_USER_ACCESS [=y]) && INET [=y] && PCI [=y] && INFINIBAND [=y] && INFINIBAND_VIRT_DMA [=y]
> > > >
> > > > This is because RDMA_RXE selects CRYPTO_CRC32,
> > > > without depending on or selecting CRYPTO, despite that config option
> > > > being subordinate to CRYPTO.
> > > >
> > > > Signed-off-by: Julian Braha <julianbraha@gmail.com>
> > >
> > > Please use git sent-email to send patches and please fix crypto Kconfig
> > > to enable CRYPTO if CRYPTO_* selected.
> > >
> > > It is a little bit awkward to request all users of CRYPTO_* to request
> > > select CRYPTO too.
> >
> > The same issue and similar patch is in this link:
> >
> > https://patchwork.kernel.org/project/linux-rdma/patch/20200915101559.33292-1-fazilyildiran@gmail.com/#23615747
>
> So what prevents us from fixing CRYPTO Kconfig?
Yes, I would like to see someone deal with this properly, either every
place doing select CRYPTO_XX needs fixing or something needs to be
done in the crypto layer.
I have no idea about kconfig to give advice, I've added Arnd since he
always seems to know :)
Thanks,
Jason
next prev parent reply other threads:[~2021-02-22 15:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 23:32 [PATCH] drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO Julian Braha
2021-02-21 6:48 ` Leon Romanovsky
2021-02-22 2:39 ` Zhu Yanjun
2021-02-22 13:00 ` Leon Romanovsky
2021-02-22 15:58 ` Jason Gunthorpe [this message]
2021-02-22 16:26 ` Randy Dunlap
2021-02-22 16:46 ` Jason Gunthorpe
2021-02-22 16:50 ` Leon Romanovsky
2021-02-22 16:53 ` Randy Dunlap
2021-02-23 20:36 ` Arnd Bergmann
2021-02-23 20:40 ` Arnd Bergmann
[not found] ` <CAJ-ZY99xZEsS5pCbZ7evi_ohozQBpHcNHDcXxfoeaLzuWRzyzw@mail.gmail.com>
2021-02-23 21:26 ` Arnd Bergmann
2021-02-23 21:54 ` Julian Braha
2021-02-23 22:05 ` Arnd Bergmann
2021-02-24 10:04 ` Leon Romanovsky
2021-03-01 18:48 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210222155845.GI2643399@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=arnd@arndb.de \
--cc=dledford@redhat.com \
--cc=julianbraha@gmail.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox