From: Jason Gunthorpe <jgg@nvidia.com>
To: Julian Braha <julianbraha@gmail.com>
Cc: <dledford@redhat.com>, <linux-rdma@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO
Date: Mon, 1 Mar 2021 14:48:23 -0400 [thread overview]
Message-ID: <20210301184823.GB745887@nvidia.com> (raw)
In-Reply-To: <21525878.NYvzQUHefP@ubuntu-mate-laptop>
On Fri, Feb 19, 2021 at 06:32:26PM -0500, Julian Braha wrote:
> commit 6e61907779ba99af785f5b2397a84077c289888a
> Author: Julian Braha <julianbraha@gmail.com>
> Date: Fri Feb 19 18:20:57 2021 -0500
>
> drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO
>
> When RDMA_RXE is enabled and CRYPTO is disabled,
> Kbuild gives the following warning:
>
> WARNING: unmet direct dependencies detected for CRYPTO_CRC32
> Depends on [n]: CRYPTO [=n]
> Selected by [y]:
> - RDMA_RXE [=y] && (INFINIBAND_USER_ACCESS [=y] || !INFINIBAND_USER_ACCESS [=y]) && INET [=y] && PCI [=y] && INFINIBAND [=y] && INFINIBAND_VIRT_DMA [=y]
>
> This is because RDMA_RXE selects CRYPTO_CRC32,
> without depending on or selecting CRYPTO, despite that config option
> being subordinate to CRYPTO.
>
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
Your patch was horribly mangled in patchworks, I fixed it, but you
need to send patches properly if you intend to send more to the kernel
Applied to for-rc
Thanks,
Jason
prev parent reply other threads:[~2021-03-01 18:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 23:32 [PATCH] drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO Julian Braha
2021-02-21 6:48 ` Leon Romanovsky
2021-02-22 2:39 ` Zhu Yanjun
2021-02-22 13:00 ` Leon Romanovsky
2021-02-22 15:58 ` Jason Gunthorpe
2021-02-22 16:26 ` Randy Dunlap
2021-02-22 16:46 ` Jason Gunthorpe
2021-02-22 16:50 ` Leon Romanovsky
2021-02-22 16:53 ` Randy Dunlap
2021-02-23 20:36 ` Arnd Bergmann
2021-02-23 20:40 ` Arnd Bergmann
[not found] ` <CAJ-ZY99xZEsS5pCbZ7evi_ohozQBpHcNHDcXxfoeaLzuWRzyzw@mail.gmail.com>
2021-02-23 21:26 ` Arnd Bergmann
2021-02-23 21:54 ` Julian Braha
2021-02-23 22:05 ` Arnd Bergmann
2021-02-24 10:04 ` Leon Romanovsky
2021-03-01 18:48 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210301184823.GB745887@nvidia.com \
--to=jgg@nvidia.com \
--cc=dledford@redhat.com \
--cc=julianbraha@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox