* [PATCH rdma-rc] RDMA/mlx5: Fix typo when prepare destroy_mkey inbox
@ 2021-03-11 14:20 Leon Romanovsky
2021-03-11 17:37 ` Jason Gunthorpe
0 siblings, 1 reply; 2+ messages in thread
From: Leon Romanovsky @ 2021-03-11 14:20 UTC (permalink / raw)
To: Doug Ledford, Jason Gunthorpe
Cc: Mark Zhang, Ido Kalir, linux-rdma, Yishai Hadas
From: Mark Zhang <markzhang@nvidia.com>
Set mkey_index to correct place when prepare destroy_mkey inbox,
this will fix the following syndrome/
mlx5_core 0000:08:00.0: mlx5_cmd_check:782:(pid 980716): DEALLOC_PD(0x801)
op_mod(0x0) failed, status bad resource state(0x9), syndrome (0x31b635)
Cc: stable@vger.kernel.org
Fixes: 1368ead04c36 ("RDMA/mlx5: Use strict get/set operations for obj_id")
Reviewed-by: Ido Kalir <idok@mellanox.com>
Reviewed-by: Yishai Hadas <yishaih@nvidia.com>
Signed-off-by: Mark Zhang <markzhang@nvidia.com>
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
---
drivers/infiniband/hw/mlx5/devx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/mlx5/devx.c b/drivers/infiniband/hw/mlx5/devx.c
index b78b5f18306d..3678b0a8710b 100644
--- a/drivers/infiniband/hw/mlx5/devx.c
+++ b/drivers/infiniband/hw/mlx5/devx.c
@@ -1116,7 +1116,7 @@ static void devx_obj_build_destroy_cmd(void *in, void *out, void *din,
case MLX5_CMD_OP_CREATE_MKEY:
MLX5_SET(destroy_mkey_in, din, opcode,
MLX5_CMD_OP_DESTROY_MKEY);
- MLX5_SET(destroy_mkey_in, in, mkey_index, *obj_id);
+ MLX5_SET(destroy_mkey_in, din, mkey_index, *obj_id);
break;
case MLX5_CMD_OP_CREATE_CQ:
MLX5_SET(destroy_cq_in, din, opcode, MLX5_CMD_OP_DESTROY_CQ);
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH rdma-rc] RDMA/mlx5: Fix typo when prepare destroy_mkey inbox
2021-03-11 14:20 [PATCH rdma-rc] RDMA/mlx5: Fix typo when prepare destroy_mkey inbox Leon Romanovsky
@ 2021-03-11 17:37 ` Jason Gunthorpe
0 siblings, 0 replies; 2+ messages in thread
From: Jason Gunthorpe @ 2021-03-11 17:37 UTC (permalink / raw)
To: Leon Romanovsky
Cc: Doug Ledford, Mark Zhang, Ido Kalir, linux-rdma, Yishai Hadas
On Thu, Mar 11, 2021 at 04:20:24PM +0200, Leon Romanovsky wrote:
> From: Mark Zhang <markzhang@nvidia.com>
>
> Set mkey_index to correct place when prepare destroy_mkey inbox,
> this will fix the following syndrome/
>
> mlx5_core 0000:08:00.0: mlx5_cmd_check:782:(pid 980716): DEALLOC_PD(0x801)
> op_mod(0x0) failed, status bad resource state(0x9), syndrome (0x31b635)
>
> Cc: stable@vger.kernel.org
> Fixes: 1368ead04c36 ("RDMA/mlx5: Use strict get/set operations for obj_id")
> Reviewed-by: Ido Kalir <idok@mellanox.com>
> Reviewed-by: Yishai Hadas <yishaih@nvidia.com>
> Signed-off-by: Mark Zhang <markzhang@nvidia.com>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> ---
> drivers/infiniband/hw/mlx5/devx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-rc thanks
Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-11 17:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-11 14:20 [PATCH rdma-rc] RDMA/mlx5: Fix typo when prepare destroy_mkey inbox Leon Romanovsky
2021-03-11 17:37 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox