From: Jason Gunthorpe <jgg@nvidia.com>
To: Devesh Sharma <devesh.sharma@broadcom.com>
Cc: Leon Romanovsky <leon@kernel.org>,
Doug Ledford <dledford@redhat.com>,
linux-rdma <linux-rdma@vger.kernel.org>,
Naresh Kumar PBS <nareshkumar.pbs@broadcom.com>,
Selvin Xavier <selvin.xavier@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Subject: Re: [PATCH rdma-next] bnxt_re: Rely on Kconfig to keep module dependency
Date: Wed, 24 Mar 2021 13:56:48 -0300 [thread overview]
Message-ID: <20210324165648.GL2356281@nvidia.com> (raw)
In-Reply-To: <CANjDDBjKbDkbwnWV=kk8m2J_NdwjOir0Uoj2xahwEMVDfu-5CQ@mail.gmail.com>
On Wed, Mar 24, 2021 at 10:00:05PM +0530, Devesh Sharma wrote:
> > > > -static void bnxt_re_dev_unprobe(struct net_device *netdev,
> > > > - struct bnxt_en_dev *en_dev)
> > > > -{
> > > > - dev_put(netdev);
> > > > - module_put(en_dev->pdev->driver->driver.owner);
> > > > -}
> > >
> > > And you are right to be wondering WTF is this
>
> Still trying to understand but what's the big idea here may be I can help.
A driver should not have module put things like the above
It should not be accessing ->driver without holding the device_lock()
Basically it is all nonsense coding, Leon suggests to delete it and he
is probably right.
Can you explain what it thinks it is doing?
Jason
next prev parent reply other threads:[~2021-03-24 16:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 14:25 [PATCH rdma-next] bnxt_re: Rely on Kconfig to keep module dependency Leon Romanovsky
2021-03-24 15:07 ` Jason Gunthorpe
2021-03-24 15:16 ` Leon Romanovsky
2021-03-24 16:30 ` Devesh Sharma
2021-03-24 16:56 ` Jason Gunthorpe [this message]
2021-03-24 17:24 ` Devesh Sharma
2021-03-24 17:35 ` Jason Gunthorpe
2021-03-25 8:40 ` Leon Romanovsky
2021-03-26 6:09 ` Devesh Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210324165648.GL2356281@nvidia.com \
--to=jgg@nvidia.com \
--cc=devesh.sharma@broadcom.com \
--cc=dledford@redhat.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=nareshkumar.pbs@broadcom.com \
--cc=selvin.xavier@broadcom.com \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox