From: Jason Gunthorpe <jgg@nvidia.com>
To: Bob Pearson <rpearsonhpe@gmail.com>
Cc: zyjzyj2000@gmail.com, linux-rdma@vger.kernel.org,
Bob Pearson <rpearson@hpe.com>
Subject: Re: [PATCH for-next v2] RDMA/rxe: Split MEM into MR and MW
Date: Tue, 30 Mar 2021 19:54:37 -0300 [thread overview]
Message-ID: <20210330225437.GD2356281@nvidia.com> (raw)
In-Reply-To: <54ec9b7c-5c43-2c36-ea51-684fd63368f9@gmail.com>
On Tue, Mar 30, 2021 at 03:46:24PM -0500, Bob Pearson wrote:
> On 3/30/21 3:12 PM, Jason Gunthorpe wrote:
> > On Thu, Mar 25, 2021 at 04:24:26PM -0500, Bob Pearson wrote:
> >> In the original rxe implementation it was intended to use a common
> >> object to represent MRs and MWs but they are different enough to
> >> separate these into two objects.
> >>
> >> This allows replacing the mem name with mr for MRs which is more
> >> consistent with the style for the other objects and less likely
> >> to be confusing. This is a long patch that mostly changes mem to
> >> mr where it makes sense and adds a new rxe_mw struct.
> >>
> >> Signed-off-by: Bob Pearson <rpearson@hpe.com>
> >> Acked-by: Zhu Yanjun <zyjzyj2000@gmail.com>
> >> v2:
> >> v1 of this patch included some fields in the new rxe_mw struct
> >> which were not yet needed. They are removed in v2.
> >> This patch includes changes needed to address the fact that
> >> the ib_mw struct is now being allocated in rdma/core.
> >
> > Applied to for-next
> >
> > I touched it with clang-format first though, lots of little whitespace
> > issues
> >
> > Thanks,
> > Jason
> >
> Thanks. Is that a stand along app or a git sub-command?
It is part of clang
https://clang.llvm.org/docs/ClangFormat.html
The sequence at the bottom is useful
git diff -U0 --no-color HEAD^ | clang-format-diff.py -i -p1
But I also have it on a current-single-statement-only hotkey in my editor
Jason
next prev parent reply other threads:[~2021-03-30 22:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 21:24 [PATCH for-next v2] RDMA/rxe: Split MEM into MR and MW Bob Pearson
2021-03-30 7:13 ` Zhu Yanjun
2021-03-30 15:09 ` Bob Pearson
2021-03-30 20:12 ` Jason Gunthorpe
2021-03-30 20:46 ` Bob Pearson
2021-03-30 22:54 ` Jason Gunthorpe [this message]
2021-03-31 19:51 ` Bob Pearson
2021-04-01 11:30 ` Jason Gunthorpe
2021-04-03 19:00 ` Bob Pearson
2021-04-04 7:41 ` Mark Bloch
2021-04-04 16:39 ` Bob Pearson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210330225437.GD2356281@nvidia.com \
--to=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearson@hpe.com \
--cc=rpearsonhpe@gmail.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox