Re: [PATCH 1/2] workqueue: Have 'alloc_workqueue()' like macros accept a format specifier

Marco Elver
2021-04-23T14:02:32Z

On Thu, Apr 22, 2021 at 01:30PM -0700, Bart Van Assche wrote:
> On 4/22/21 11:00 AM, Leon Romanovsky wrote:
> > On Thu, Apr 22, 2021 at 10:12:33AM -0700, Bart Van Assche wrote:
> > > On 4/22/21 5:24 AM, Jason Gunthorpe wrote:
> > > > On Mon, Apr 19, 2021 at 01:02:34PM -0700, Bart Van Assche wrote:
> > > > > On 4/18/21 11:36 PM, Marion et Christophe JAILLET wrote:
> > > > > > The list in To: is the one given by get_maintainer.pl. Usualy, I only
> > > > > > put the ML in Cc: I've run the script on the 2 patches of the serie
> > > > > > and merged the 2 lists. Everyone is in the To: of the cover letter
> > > > > > and of the 2 patches.
> > > > > >
> > > > > > If Théo is "Tejun Heo" ( (maintainer:WORKQUEUE) ), he is already in
> > > > > > the To: line.
> > > > > Linus wants to see a "Cc: ${maintainer}" tag in patches that he receives
> > > > > from a maintainer and that modify another subsystem than the subsystem
> > > > > maintained by that maintainer.
> > > >
> > > > Really? Do you remember a lore link for this?
> > >
> > > Last time I saw Linus mentioning this was a few months ago.
> > > Unfortunately I cannot find that message anymore.
> > >
> > > > Generally I've been junking the CC lines (vs Andrew at the other
> > > > extreme that often has 10's of CC lines)
> > >
> > > Most entries in the MAINTAINERS file have one to three email addresses
> > > so I'm surprised to read that Cc-ing maintainer(s) could result in tens
> > > of Cc lines?
> >
> > git log mm/
> >
> > commit 2b8305260fb37fc20e13f71e13073304d0a031c8
> > Author: Alexander Potapenko <glider@google.com>
> > Date: Thu Feb 25 17:19:21 2021 -0800
> >
> > kfence, kasan: make KFENCE compatible with KASAN
> >
> > Make KFENCE compatible with KASAN. Currently this helps test KFENCE
> > itself, where KASAN can catch potential corruptions to KFENCE state, or
> > other corruptions that may be a result of freepointer corruptions in the
> > main allocators.
> >
> > [akpm@linux-foundation.org: merge fixup]
> > [andreyknvl@google.com: untag addresses for KFENCE]
> > Link: https://lkml.kernel.org/r/9dc196006921b191d25d10f6e611316db7da2efc.1611946152.git.andreyknvl@google.com
> >
> > Link: https://lkml.kernel.org/r/20201103175841.3495947-7-elver@google.com
> > Signed-off-by: Marco Elver <elver@google.com>
> > Signed-off-by: Alexander Potapenko <glider@google.com>
> > Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
> > Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
> > Reviewed-by: Jann Horn <jannh@google.com>
> > Co-developed-by: Marco Elver <elver@google.com>
> > Cc: Andrey Konovalov <andreyknvl@google.com>
> > Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>
> > Cc: Andy Lutomirski <luto@kernel.org>
> > Cc: Borislav Petkov <bp@alien8.de>
> > Cc: Catalin Marinas <catalin.marinas@arm.com>
> > Cc: Christopher Lameter <cl@linux.com>
> > Cc: Dave Hansen <dave.hansen@linux.intel.com>
> > Cc: David Rientjes <rientjes@google.com>
> > Cc: Eric Dumazet <edumazet@google.com>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: Hillf Danton <hdanton@sina.com>
> > Cc: "H. Peter Anvin" <hpa@zytor.com>
> > Cc: Ingo Molnar <mingo@redhat.com>
> > Cc: Joern Engel <joern@purestorage.com>
> > Cc: Jonathan Corbet <corbet@lwn.net>
> > Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> > Cc: Kees Cook <keescook@chromium.org>
> > Cc: Mark Rutland <mark.rutland@arm.com>
> > Cc: Paul E. McKenney <paulmck@kernel.org>
> > Cc: Pekka Enberg <penberg@kernel.org>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: SeongJae Park <sjpark@amazon.de>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Vlastimil Babka <vbabka@suse.cz>
> > Cc: Will Deacon <will@kernel.org>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> > Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

This is a special case probably as KFENCE touched various subsystems and
architectures.

That Cc list is from the original

https://lkml.kernel.org/r/20201103175841.3495947-7-elver@google.com

It was determined based on the full series, mostly from a
get_maintainer.pl of 'reviewer' and 'maintainer' lists of the full
series diff, minus a some false positives to avoid spamming people, and
plus a few people get_maintainer.pl missed that had provided or could
provide useful input. So the list above is mostly maintainers+reviewers
of mm/, mm/kasan, arch/x86, and arch/arm64.

> But where does that Cc-list come from? If I extract that patch and run the
> get_maintainer.pl script, the following output appears:
>
> $ git format-patch -1 2b8305260fb37fc20e13f71e13073304d0a031c8
> 0001-kfence-kasan-make-KFENCE-compatible-with-KASAN.patch
> $ scripts/get_maintainer.pl
> 0001-kfence-kasan-make-KFENCE-compatible-with-KASAN.patch
> Alexander Potapenko <glider@google.com> (maintainer:KFENCE)
> Marco Elver <elver@google.com> (maintainer:KFENCE)

KFENCE did not yet exist when the patch the above series was part of was
posted... so chicken and egg situation here. ;-)

> Dmitry Vyukov <dvyukov@google.com> (reviewer:KFENCE)
> Andrey Ryabinin <ryabinin.a.a@gmail.com> (maintainer:KASAN)
> Andrey Konovalov <andreyknvl@gmail.com> (reviewer:KASAN)
> Andrew Morton <akpm@linux-foundation.org> (maintainer:MEMORY MANAGEMENT)
> kasan-dev@googlegroups.com (open list:KFENCE)
> linux-kernel@vger.kernel.org (open list)
> linux-mm@kvack.org (open list:MEMORY MANAGEMENT)

Thanks,
-- Marco