From: Zhen Lei <thunder.leizhen@huawei.com>
To: Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
"Leon Romanovsky" <leon@kernel.org>,
linux-rdma <linux-rdma@vger.kernel.org>
Cc: Zhen Lei <thunder.leizhen@huawei.com>
Subject: [PATCH v2 1/2] RDMA/cm: Delete two redundant condition branches
Date: Wed, 12 May 2021 18:05:36 +0800 [thread overview]
Message-ID: <20210512100537.6273-2-thunder.leizhen@huawei.com> (raw)
In-Reply-To: <20210512100537.6273-1-thunder.leizhen@huawei.com>
The statement of the last "if (xxx)" branch is the same as the "else"
branch. Delete it to simplify code.
No functional change.
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/infiniband/core/cm.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/infiniband/core/cm.c b/drivers/infiniband/core/cm.c
index 0ead0d223154011..510beb25f5b8a0b 100644
--- a/drivers/infiniband/core/cm.c
+++ b/drivers/infiniband/core/cm.c
@@ -668,8 +668,6 @@ static struct cm_id_private *cm_insert_listen(struct cm_id_private *cm_id_priv,
link = &(*link)->rb_right;
else if (be64_lt(service_id, cur_cm_id_priv->id.service_id))
link = &(*link)->rb_left;
- else if (be64_gt(service_id, cur_cm_id_priv->id.service_id))
- link = &(*link)->rb_right;
else
link = &(*link)->rb_right;
}
@@ -700,8 +698,6 @@ static struct cm_id_private *cm_find_listen(struct ib_device *device,
node = node->rb_right;
else if (be64_lt(service_id, cm_id_priv->id.service_id))
node = node->rb_left;
- else if (be64_gt(service_id, cm_id_priv->id.service_id))
- node = node->rb_right;
else
node = node->rb_right;
}
--
2.26.0.106.g9fadedd
next prev parent reply other threads:[~2021-05-12 10:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 10:05 [PATCH v2 0/2] RDMA/cm: Optimise rbtree searching Zhen Lei
2021-05-12 10:05 ` Zhen Lei [this message]
2021-05-12 10:05 ` [PATCH v2 2/2] " Zhen Lei
2021-05-12 12:50 ` Jason Gunthorpe
2021-05-12 13:12 ` Leizhen (ThunderTown)
2021-05-12 14:26 ` Jason Gunthorpe
2021-05-13 2:25 ` Leizhen (ThunderTown)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210512100537.6273-2-thunder.leizhen@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox