From: Jason Gunthorpe <jgg@nvidia.com>
To: Gal Pressman <galpress@amazon.com>
Cc: Potnuri Bharat Teja <bharat@chelsio.com>,
Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
Devesh Sharma <devesh.sharma@broadcom.com>,
Doug Ledford <dledford@redhat.com>,
Faisal Latif <faisal.latif@intel.com>,
Leon Romanovsky <leon@kernel.org>,
linux-rdma@vger.kernel.org,
Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>,
Naresh Kumar PBS <nareshkumar.pbs@broadcom.com>,
Selvin Xavier <selvin.xavier@broadcom.com>,
Shiraz Saleem <shiraz.saleem@intel.com>,
Yossi Leybovich <sleybo@amazon.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>,
Yishai Hadas <yishaih@nvidia.com>,
Zhu Yanjun <zyjzyj2000@gmail.com>,
Greg KH <gregkh@linuxfoundation.org>,
Kees Cook <keescook@chromium.org>,
Nathan Chancellor <nathan@kernel.org>
Subject: Re: [PATCH 01/13] RDMA: Split the alloc_hw_stats() ops to port and device variants
Date: Wed, 19 May 2021 10:44:18 -0300 [thread overview]
Message-ID: <20210519134418.GL1002214@nvidia.com> (raw)
In-Reply-To: <2cdd5b33-1e54-779b-53b4-054d734b5eb2@amazon.com>
On Wed, May 19, 2021 at 02:29:57PM +0300, Gal Pressman wrote:
> On 17/05/2021 19:47, Jason Gunthorpe wrote:
> > +struct rdma_hw_stats *efa_alloc_hw_device_stats(struct ib_device *ibdev)
> > +{
> > + /*
> > + * It is probably a bug that efa reports its port stats as device
> > + * stats
> > + */
>
> Hmm, yea this needs some work.
> Most of these stats are in fact port stats, but others (admin commands,
> keep-alive, allocation/creation error) are device stats.
>
> You can split them if you wish, or I can send a followup patch.
I'm not sure I'd guess right, you'd probably better take it
> Thanks,
> Tested-by: Gal Pressman <galpress@amazon.com>
Thanks,
Jason
next prev parent reply other threads:[~2021-05-19 13:44 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 16:47 [PATCH 00/13] Reorganize sysfs file creation for struct ib_devices Jason Gunthorpe
2021-05-17 16:47 ` [PATCH 01/13] RDMA: Split the alloc_hw_stats() ops to port and device variants Jason Gunthorpe
2021-05-17 23:06 ` Saleem, Shiraz
2021-05-17 23:10 ` Jason Gunthorpe
2021-05-18 0:18 ` Saleem, Shiraz
2021-05-18 0:20 ` Jason Gunthorpe
2021-05-18 21:58 ` Saleem, Shiraz
2021-05-19 12:25 ` Jason Gunthorpe
2021-05-19 16:50 ` Saleem, Shiraz
2021-05-18 3:49 ` Mark Zhang
2021-05-19 1:10 ` Saleem, Shiraz
2021-05-20 16:29 ` Jason Gunthorpe
2021-05-19 11:29 ` Gal Pressman
2021-05-19 13:44 ` Jason Gunthorpe [this message]
2021-05-17 16:47 ` [PATCH 02/13] RDMA/core: Replace the ib_port_data hw_stats pointers with a ib_port pointer Jason Gunthorpe
2021-05-17 16:47 ` [PATCH 03/13] RDMA/core: Split port and device counter sysfs attributes Jason Gunthorpe
2021-05-17 16:47 ` [PATCH 04/13] RDMA/core: Split gid_attrs related sysfs from add_port() Jason Gunthorpe
2021-05-17 16:47 ` [PATCH 05/13] RDMA/core: Simplify how the gid_attrs sysfs is created Jason Gunthorpe
2021-05-17 16:47 ` [PATCH 06/13] RDMA/core: Simplify how the port " Jason Gunthorpe
2021-05-17 16:47 ` [PATCH 07/13] RDMA/core: Create the device hw_counters through the normal groups mechanism Jason Gunthorpe
2021-05-17 16:47 ` [PATCH 08/13] RDMA/core: Remove the kobject_uevent() NOP Jason Gunthorpe
2021-05-17 16:47 ` [PATCH 09/13] RDMA/core: Expose the ib port sysfs attribute machinery Jason Gunthorpe
2021-05-17 17:12 ` Greg KH
2021-05-17 17:31 ` Jason Gunthorpe
2021-05-17 17:37 ` Greg KH
2021-05-17 16:47 ` [PATCH 10/13] RDMA/cm: Use an attribute_group on the ib_port_attribute intead of kobj's Jason Gunthorpe
2021-05-17 16:47 ` [PATCH 11/13] RDMA/qib: Use attributes for the port sysfs Jason Gunthorpe
2021-05-17 17:11 ` Greg KH
2021-05-17 17:13 ` Jason Gunthorpe
2021-05-17 17:31 ` Greg KH
2021-05-17 18:44 ` Jason Gunthorpe
2021-05-17 16:47 ` [PATCH 12/13] RDMA/hfi1: " Jason Gunthorpe
2021-05-17 16:47 ` [PATCH 13/13] RDMA: Change ops->init_port to ops->get_port_groups Jason Gunthorpe
2021-05-18 23:07 ` [PATCH 00/13] Reorganize sysfs file creation for struct ib_devices Nathan Chancellor
2021-05-19 13:46 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210519134418.GL1002214@nvidia.com \
--to=jgg@nvidia.com \
--cc=bharat@chelsio.com \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=devesh.sharma@broadcom.com \
--cc=dledford@redhat.com \
--cc=faisal.latif@intel.com \
--cc=galpress@amazon.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@cornelisnetworks.com \
--cc=nareshkumar.pbs@broadcom.com \
--cc=nathan@kernel.org \
--cc=selvin.xavier@broadcom.com \
--cc=shiraz.saleem@intel.com \
--cc=sleybo@amazon.com \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
--cc=yishaih@nvidia.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox