* [PATCH] RDMA/cxgb4: removing useless assignments
@ 2021-05-20 9:39 Tian Tao
2021-05-20 15:30 ` Jason Gunthorpe
0 siblings, 1 reply; 2+ messages in thread
From: Tian Tao @ 2021-05-20 9:39 UTC (permalink / raw)
To: bharat, dledford, jgg; +Cc: linux-rdma, Tian Tao
If go to the err label, abort will be assigned a value of 1, so there
is no need to assign a value of 1 here.
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
drivers/infiniband/hw/cxgb4/qp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/infiniband/hw/cxgb4/qp.c b/drivers/infiniband/hw/cxgb4/qp.c
index d109bb3..1b078d5 100644
--- a/drivers/infiniband/hw/cxgb4/qp.c
+++ b/drivers/infiniband/hw/cxgb4/qp.c
@@ -1963,7 +1963,6 @@ int c4iw_modify_qp(struct c4iw_dev *rhp, struct c4iw_qp *qhp,
t4_set_wq_in_error(&qhp->wq, 0);
set_state(qhp, C4IW_QP_STATE_ERROR);
if (!internal) {
- abort = 1;
disconnect = 1;
ep = qhp->ep;
c4iw_get_ep(&qhp->ep->com);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] RDMA/cxgb4: removing useless assignments
2021-05-20 9:39 [PATCH] RDMA/cxgb4: removing useless assignments Tian Tao
@ 2021-05-20 15:30 ` Jason Gunthorpe
0 siblings, 0 replies; 2+ messages in thread
From: Jason Gunthorpe @ 2021-05-20 15:30 UTC (permalink / raw)
To: Tian Tao; +Cc: bharat, dledford, linux-rdma
On Thu, May 20, 2021 at 05:39:37PM +0800, Tian Tao wrote:
> If go to the err label, abort will be assigned a value of 1, so there
> is no need to assign a value of 1 here.
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> ---
> drivers/infiniband/hw/cxgb4/qp.c | 1 -
> 1 file changed, 1 deletion(-)
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-20 15:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-20 9:39 [PATCH] RDMA/cxgb4: removing useless assignments Tian Tao
2021-05-20 15:30 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox