Re: [PATCH for-next v2] IB/core: Only update PKEY and GID caches on respective events

[Jason Gunthorpe <jgg@nvidia.com>]

On Mon, May 24, 2021 at 10:26:16AM +0000, Haakon Bugge wrote:
> 
> 
> > On 9 May 2021, at 09:47, Leon Romanovsky <leon@kernel.org> wrote:
> > 
> > On Thu, May 06, 2021 at 10:31:44AM +0200, Håkon Bugge wrote:
> >> Both the PKEY and GID tables in an HCA can hold in the order of
> >> hundreds entries. Reading them are expensive. Partly because the API
> >> for retrieving them only returns a single entry at a time. Further, on
> >> certain implementations, e.g., CX-3, the VFs are paravirtualized in
> >> this respect and have to rely on the PF driver to perform the
> >> read. This again demands VF to PF communication.
> >> 
> >> IB Core's cache is refreshed on all events. Hence, filter the refresh
> >> of the PKEY and GID caches based on the event received being
> >> IB_EVENT_PKEY_CHANGE and IB_EVENT_GID_CHANGE respectively.
> >> 
> >> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> >> Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
> >> 
> >> 
> >> v1 -> v2:
> >>   * Changed signature of ib_cache_update() as per Leon's suggestion
> >>   * Added Fixes tag as per Zhu Yanjun' suggestion
> >> drivers/infiniband/core/cache.c | 23 +++++++++++++++--------
> >> 1 file changed, 15 insertions(+), 8 deletions(-)
> >> 
> > 
> > Thanks,
> > Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
> 
> I saw a handful commits being applied for-next. Anything needed from my side here?

It doesn't apply please resend it

Jason