From: Jason Gunthorpe <jgg@nvidia.com>
To: Gioh Kim <gi-oh.kim@ionos.com>
Cc: linux-rdma@vger.kernel.org, bvanassche@acm.org, leon@kernel.org,
dledford@redhat.com, haris.iqbal@ionos.com, jinpu.wang@ionos.com,
Md Haris Iqbal <haris.iqbal@cloud.ionos.com>
Subject: Re: [PATCHv2 for-next 03/19] RDMA/rtrs-srv: Add error messages for cases when failing RDMA connection
Date: Tue, 25 May 2021 17:18:23 -0300 [thread overview]
Message-ID: <20210525201823.GA3482566@nvidia.com> (raw)
In-Reply-To: <20210517091844.260810-4-gi-oh.kim@ionos.com>
On Mon, May 17, 2021 at 11:18:27AM +0200, Gioh Kim wrote:
> From: Md Haris Iqbal <haris.iqbal@cloud.ionos.com>
>
> It was difficult to find out why it failed to establish RDMA
> connection. This patch adds some messages to show which function
> has failed why.
>
> Signed-off-by: Md Haris Iqbal <haris.iqbal@ionos.com>
> Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
> Signed-off-by: Gioh Kim <gi-oh.kim@ionos.com>
> ---
> drivers/infiniband/ulp/rtrs/rtrs-srv.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/ulp/rtrs/rtrs-srv.c b/drivers/infiniband/ulp/rtrs/rtrs-srv.c
> index 3d09d01e34b4..df17dd4c1e28 100644
> --- a/drivers/infiniband/ulp/rtrs/rtrs-srv.c
> +++ b/drivers/infiniband/ulp/rtrs/rtrs-srv.c
> @@ -1356,8 +1356,10 @@ static struct rtrs_srv *get_or_create_srv(struct rtrs_srv_ctx *ctx,
> * If this request is not the first connection request from the
> * client for this session then fail and return error.
> */
> - if (!first_conn)
> + if (!first_conn) {
> + pr_err("Error: Not the first connection request for this session\n");
> return ERR_PTR(-ENXIO);
You really shouldn't be printing based on attacker controlled data..
Jason
next prev parent reply other threads:[~2021-05-25 20:18 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 9:18 [PATCHv2 for-next 00/19] Misc update for rtrs Gioh Kim
2021-05-17 9:18 ` [PATCHv2 for-next 01/19] RDMA/rtrs-srv: Kill reject_w_econnreset label Gioh Kim
2021-05-17 9:18 ` [PATCHv2 for-next 02/19] RDMA/rtrs-clt: Remove MAX_SESS_QUEUE_DEPTH from rtrs_send_sess_info Gioh Kim
2021-05-17 9:18 ` [PATCHv2 for-next 03/19] RDMA/rtrs-srv: Add error messages for cases when failing RDMA connection Gioh Kim
2021-05-25 20:18 ` Jason Gunthorpe [this message]
2021-05-26 9:28 ` Haris Iqbal
2021-05-26 16:07 ` Jason Gunthorpe
2021-05-27 9:26 ` Haris Iqbal
2021-05-17 9:18 ` [PATCHv2 for-next 04/19] RDMA/rtrs-srv: Clean up the code in __rtrs_srv_change_state Gioh Kim
2021-05-17 9:18 ` [PATCHv2 for-next 05/19] RDMA/rtrs: Change MAX_SESS_QUEUE_DEPTH Gioh Kim
2021-05-17 9:18 ` [PATCHv2 for-next 06/19] RDMA/rtrs: Define MIN_CHUNK_SIZE Gioh Kim
2021-05-17 9:18 ` [PATCHv2 for-next 07/19] RDMA/rtrs: Use strscpy instead of strlcpy Gioh Kim
2021-05-17 9:18 ` [PATCHv2 for-next 08/19] RDMA/rtrs-clt: Kill rtrs_clt_{start,stop}_hb Gioh Kim
2021-05-17 9:18 ` [PATCHv2 for-next 09/19] RDMA/rtrs-clt: Kill rtrs_clt_disconnect_from_sysfs Gioh Kim
2021-05-17 9:18 ` [PATCHv2 for-next 10/19] RDMA/rtrs-srv: Kill __rtrs_srv_change_state Gioh Kim
2021-05-17 9:18 ` [PATCHv2 for-next 11/19] RDMA/rtrs-clt: Remove redundant 'break' Gioh Kim
2021-05-17 9:18 ` [PATCHv2 for-next 12/19] RDMA/rtrs-clt: Check state of the rtrs_clt_sess before reading its stats Gioh Kim
2021-05-17 9:18 ` [PATCHv2 for-next 13/19] RDMA/rtrs-srv: Replace atomic_t with percpu_ref for ids_inflight Gioh Kim
2021-05-25 20:15 ` Jason Gunthorpe
2021-05-26 9:16 ` Haris Iqbal
2021-05-26 9:38 ` Jinpu Wang
2021-05-27 9:25 ` Haris Iqbal
2021-05-17 9:18 ` [PATCHv2 for-next 14/19] RDMA/rtrs: Do not reset hb_missed_max after re-connection Gioh Kim
2021-05-17 9:18 ` [PATCHv2 for-next 15/19] RDMA/rtrs-srv: Duplicated session name is not allowed Gioh Kim
2021-05-17 9:18 ` [PATCHv2 for-next 16/19] RDMA/rtrs-srv: Fix memory leak of unfreed rtrs_srv_stats object Gioh Kim
2021-05-17 9:18 ` [PATCHv2 for-next 17/19] RDMA/rtrs-srv: Fix memory leak when having multiple sessions Gioh Kim
2021-05-17 9:18 ` [PATCHv2 for-next 18/19] RDMA/rtrs-clt: Check if the queue_depth has changed during a reconnection Gioh Kim
2021-05-17 9:18 ` [PATCHv2 for-next 19/19] RDMA/rtrs-clt: Fix memory leak of not-freed sess->stats and stats->pcpu_stats Gioh Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210525201823.GA3482566@nvidia.com \
--to=jgg@nvidia.com \
--cc=bvanassche@acm.org \
--cc=dledford@redhat.com \
--cc=gi-oh.kim@ionos.com \
--cc=haris.iqbal@cloud.ionos.com \
--cc=haris.iqbal@ionos.com \
--cc=jinpu.wang@ionos.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox