public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Haakon Bugge <haakon.bugge@oracle.com>
Cc: Leon Romanovsky <leon@kernel.org>,
	Doug Ledford <dledford@redhat.com>,
	OFED mailing list <linux-rdma@vger.kernel.org>,
	Hans Ry <hans.westgaard.ry@oracle.com>
Subject: Re: [PATCH for-next v2] RDMA/cma: Replace RMW with atomic bit-ops
Date: Mon, 21 Jun 2021 12:12:40 -0300	[thread overview]
Message-ID: <20210621151240.GQ1002214@nvidia.com> (raw)
In-Reply-To: <36906AC6-B2DB-40D4-972C-8058FF0B462C@oracle.com>

On Mon, Jun 21, 2021 at 02:58:46PM +0000, Haakon Bugge wrote:
> 
> 
> > On 21 Jun 2021, at 16:37, Jason Gunthorpe <jgg@nvidia.com> wrote:
> > 
> > On Mon, Jun 21, 2021 at 10:46:26AM +0000, Haakon Bugge wrote:
> > 
> >>>> You're running an old checkpatch. Since commit bdc48fa11e46 ("checkpatch/coding-style: deprecate 80-column warning"), the default line-length is 100. As Linus states in:
> >>>> 
> >>>> https://lkml.org/lkml/2009/12/17/229
> >>>> 
> >>>> "... But 80 characters is causing too many idiotic changes."
> >>> 
> >>> I'm aware of that thread, but RDMA subsystem continues to use 80 symbols limit.
> >> 
> >> I wasn't aware. Where is that documented? Further, it must be a
> >> limit that is not enforced. Of the last 100 commits in
> >> drivers/infiniband, there are 630 lines longer than 80.
> > 
> > Linus said stick to 80 but use your best judgement if going past
> > 
> > It was not a blanket allowance to needless long lines all over the
> > place.
> 
> That is not how I interpreted him:

There was a much newer thread on this from Linus, 2009 is really old

Jason

  reply	other threads:[~2021-06-21 15:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-17 12:59 [PATCH for-next v2] RDMA/cma: Replace RMW with atomic bit-ops Håkon Bugge
2021-06-21  7:10 ` Leon Romanovsky
2021-06-21  8:20   ` Haakon Bugge
2021-06-21  9:54     ` Leon Romanovsky
2021-06-21 10:46       ` Haakon Bugge
2021-06-21 14:37         ` Jason Gunthorpe
2021-06-21 14:58           ` Haakon Bugge
2021-06-21 15:12             ` Jason Gunthorpe [this message]
2021-06-21 15:55               ` Haakon Bugge
2021-06-21 23:31                 ` Jason Gunthorpe
2021-06-22  6:16                 ` Leon Romanovsky
2021-06-22  7:06                   ` Haakon Bugge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210621151240.GQ1002214@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=dledford@redhat.com \
    --cc=haakon.bugge@oracle.com \
    --cc=hans.westgaard.ry@oracle.com \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox