From: Jason Gunthorpe <jgg@nvidia.com>
To: Bob Pearson <rpearsonhpe@gmail.com>
Cc: zyjzyj2000@gmail.com, linux-rdma@vger.kernel.org
Subject: Re: [PATCH for-next 0/6] Fix extra/redundant copies
Date: Tue, 22 Jun 2021 15:40:22 -0300 [thread overview]
Message-ID: <20210622184022.GA2595597@nvidia.com> (raw)
In-Reply-To: <20210618045742.204195-1-rpearsonhpe@gmail.com>
On Thu, Jun 17, 2021 at 11:57:37PM -0500, Bob Pearson wrote:
> This series of patches removes or shortens several unneeded passes over
> packet data.
>
> Applies cleanly to for-next after the memory windows commits.
>
> Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com>
>
> Bob Pearson (6):
> RDMA/rxe: Fix useless copy in send_atomic_ack
> RDMA/rxe: Fix redundant call to ip_send_check
> RDMA/rxe: Fix extra copies in build_rdma_network_hdr
> RDMA/rxe: Fix over copying in get_srq_wqe
> RDMA/rxe: Fix extra copy in prepare_ack_packet
> RDMA/rxe: Fix redundant skb_put_zero
I'm inclined to agree with Bob that the network fast path should not
rely on pre-zeroing but each written header should zero or write valid
data as it goes, for performance
So applied to for-next, thanks
Jason
prev parent reply other threads:[~2021-06-22 18:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 4:57 [PATCH for-next 0/6] Fix extra/redundant copies Bob Pearson
2021-06-18 4:57 ` [PATCH for-next 1/6] RDMA/rxe: Fix useless copy in send_atomic_ack Bob Pearson
2021-06-18 4:57 ` [PATCH for-next 2/6] RDMA/rxe: Fix redundant call to ip_send_check Bob Pearson
2021-06-18 4:57 ` [PATCH for-next 3/6] RDMA/rxe: Fix extra copies in build_rdma_network_hdr Bob Pearson
2021-06-18 4:57 ` [PATCH for-next 4/6] RDMA/rxe: Fix over copying in get_srq_wqe Bob Pearson
2021-06-18 4:57 ` [PATCH for-next 5/6] RDMA/rxe: Fix extra copy in prepare_ack_packet Bob Pearson
2021-06-18 4:57 ` [PATCH for-next 6/6] RDMA/rxe: Fix redundant skb_put_zero Bob Pearson
2021-06-18 8:02 ` Zhu Yanjun
2021-06-18 15:32 ` Bob Pearson
2021-06-20 14:07 ` Zhu Yanjun
2021-06-20 20:21 ` Bob Pearson
2021-06-21 2:58 ` Zhu Yanjun
2021-06-22 18:40 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210622184022.GA2595597@nvidia.com \
--to=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearsonhpe@gmail.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox