From: Jason Gunthorpe <jgg@nvidia.com>
To: Bob Pearson <rpearsonhpe@gmail.com>
Cc: Leon Romanovsky <leon@kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: rxe MW PR for rdma-core
Date: Fri, 25 Jun 2021 11:39:24 -0300 [thread overview]
Message-ID: <20210625143924.GU2371267@nvidia.com> (raw)
In-Reply-To: <29c7ec8a-3190-cb75-855d-f8c9b483d896@gmail.com>
On Thu, Jun 24, 2021 at 11:59:14PM -0500, Bob Pearson wrote:
> It took a few hours but I finally managed to get rid of the merge
> commits in the rxe MW PR. It's back out there at github. I lost the
> name change Jason had made when I deleted and reforked my repo. I
> remade the update kernel headers commit without the ??. It still
> passes all the screening tests.
You should never have to delete and refork with git.
Force push fixes all mistakes.
The sequence to fix your situation is
1) Starting at the bad branch merge to latest rdma-core
2) Create a new branch on latest rdma-core
3) Use 'git cherry-pick' on each non-merge commit from the
bad branch
4) Diff the bad/good branch to make sure nothing got missed in the
merges
5) Reset the bad branch to the new branch's commit ID.
6) Force push the fixed branch to github.
In future use 'git rebase' instead of 'git merge'
Jason
next prev parent reply other threads:[~2021-06-25 14:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 4:59 rxe MW PR for rdma-core Bob Pearson
2021-06-25 14:39 ` Jason Gunthorpe [this message]
2021-06-25 15:04 ` Bob Pearson
2021-06-25 16:20 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210625143924.GU2371267@nvidia.com \
--to=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearsonhpe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox