From: Jason Gunthorpe <jgg@nvidia.com>
To: Jack Wang <jinpu.wang@ionos.com>
Cc: linux-rdma@vger.kernel.org, bvanassche@acm.org, leon@kernel.org,
dledford@redhat.com, haris.iqbal@ionos.com
Subject: Re: [PATCHv2 for-rc 0/6] Bugfixes for send queue overflow by heartbeat
Date: Mon, 12 Jul 2021 14:35:35 -0300 [thread overview]
Message-ID: <20210712173535.GA258722@nvidia.com> (raw)
In-Reply-To: <20210712060750.16494-1-jinpu.wang@ionos.com>
On Mon, Jul 12, 2021 at 08:07:44AM +0200, Jack Wang wrote:
> Hi Jason, hi Doug,
>
> Please consider to include following changes to upstream.
>
> This patchset fix a regression since b38041d50add ("RDMA/rtrs: Do not signal for heatbeat").
>
> In commit b38041d50add, the signal flag is droped to fix the send queue full
> logic, but introduced a worse bug the send queue overflow on both clt and srv
> by heartbeat, sorry.
>
> The patchset is orgnized as:
> - patch1 debug patch.
> - patch2 preparation.
> - patch3 signal both IO and heartbeat.
> - patch4 cleanup.
> - patch5 cleanup
> - patch6 move sq_wr_avail to account send queue full correctly.
>
> The patches are created base v5.14-rc1.
>
> Since v1:
> * rebased to latest v5.14-rc1, target rc instread of for-next.
>
> v1: https://lore.kernel.org/linux-rdma/20210629065321.12600-1-jinpu.wang@ionos.com/T/#t
>
> Jack Wang (6):
> RDMA/rtrs: Add error messages for failed operations.
> RDMA/rtrs: move wr_cnt from rtrs_srv_con to rtrs_con
> RDMA/rtrs: Enable the same selective signal for heartbeat and IO
> RDMA/rtrs: Make rtrs_post_rdma_write_imm_empty static
> RDMA/rtrs: Remove unused flags parameter
> RDMA/rtrs: Move sq_wr_avail to rtrs_con
This is not really structured well enough for a -rc patch. There
should be no unncessary changes and each patch should try to be self
contained. Avoid "cleanup". Carefully describe what user visible
defect each patch is fixing.
If you really want it to be in -rc then it needs reorganizing,
otherwise I can put it in -next
Jason
next prev parent reply other threads:[~2021-07-12 17:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 6:07 [PATCHv2 for-rc 0/6] Bugfixes for send queue overflow by heartbeat Jack Wang
2021-07-12 6:07 ` [PATCHv2 for-rc 1/6] RDMA/rtrs: Add error messages for failed operations Jack Wang
2021-07-12 6:07 ` [PATCHv2 for-rc 2/6] RDMA/rtrs: move wr_cnt from rtrs_srv_con to rtrs_con Jack Wang
2021-07-12 6:07 ` [PATCHv2 for-rc 3/6] RDMA/rtrs: Enable the same selective signal for heartbeat and IO Jack Wang
2021-07-12 6:07 ` [PATCHv2 for-rc 4/6] RDMA/rtrs: Make rtrs_post_rdma_write_imm_empty static Jack Wang
2021-07-12 6:07 ` [PATCHv2 for-rc 5/6] RDMA/rtrs: Remove unused flags parameter Jack Wang
2021-07-12 6:07 ` [PATCHv2 for-rc 6/6] RDMA/rtrs: Move sq_wr_avail to rtrs_con Jack Wang
2021-07-12 17:35 ` Jason Gunthorpe [this message]
2021-07-12 18:58 ` [PATCHv2 for-rc 0/6] Bugfixes for send queue overflow by heartbeat Jinpu Wang
2021-07-15 17:41 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210712173535.GA258722@nvidia.com \
--to=jgg@nvidia.com \
--cc=bvanassche@acm.org \
--cc=dledford@redhat.com \
--cc=haris.iqbal@ionos.com \
--cc=jinpu.wang@ionos.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox