From: Jason Gunthorpe <jgg@nvidia.com>
To: Bob Pearson <rpearsonhpe@gmail.com>
Cc: zyjzyj2000@gmail.com, linux-rdma@vger.kernel.org
Subject: Re: [PATCH 1/5] RDMA/rxe: Change user/kernel API to allow indexing AH
Date: Fri, 16 Jul 2021 14:44:12 -0300 [thread overview]
Message-ID: <20210716174412.GA768036@nvidia.com> (raw)
In-Reply-To: <20210628220043.9851-2-rpearsonhpe@gmail.com>
On Mon, Jun 28, 2021 at 05:00:40PM -0500, Bob Pearson wrote:
> Make changes to rdma_user_rxe.h to allow indexing AH objects, passing
> the index in UD send WRs to the driver and returning the index to the rxe
> provider. This change will allow removing handling of the AV in the user
> space provider. This change is backwards compatible with the current API
> so new or old providers and drivers can work together.
>
> Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com>
> include/uapi/rdma/rdma_user_rxe.h | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/include/uapi/rdma/rdma_user_rxe.h b/include/uapi/rdma/rdma_user_rxe.h
> index e283c2220aba..e544832ed073 100644
> +++ b/include/uapi/rdma/rdma_user_rxe.h
> @@ -98,6 +98,8 @@ struct rxe_send_wr {
> __u32 remote_qpn;
> __u32 remote_qkey;
> __u16 pkey_index;
> + __u16 reserved;
> + __u32 ah_num;
> } ud;
> struct {
> __aligned_u64 addr;
> @@ -148,7 +150,12 @@ struct rxe_dma_info {
>
> struct rxe_send_wqe {
> struct rxe_send_wr wr;
> - struct rxe_av av;
> + union {
> + struct rxe_av av;
> + struct {
> + __u32 reserved[0];
> + } ex;
> + };
What is this for? I didn't notice a usage?
Jason
next prev parent reply other threads:[~2021-07-16 17:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 22:00 [PATCH for-next 0/5] Replace AV by AH in UD sends Bob Pearson
2021-06-28 22:00 ` [PATCH 1/5] RDMA/rxe: Change user/kernel API to allow indexing AH Bob Pearson
2021-07-16 17:44 ` Jason Gunthorpe [this message]
2021-07-16 17:55 ` Bob Pearson
2021-07-16 18:03 ` Jason Gunthorpe
2021-06-28 22:00 ` [PATCH 2/5] RDMA/rxe: Change AH objects to indexed Bob Pearson
2021-06-28 22:00 ` [PATCH 3/5] RDMA/rxe: Create AH index and return to user space Bob Pearson
2021-06-28 22:00 ` [PATCH 4/5] RDMA/rxe: Lookup kernel AH from ah index in UD WQEs Bob Pearson
2021-06-28 22:00 ` [PATCH 5/5] RDMA/rxe: Convert kernel UD post send to use ah_num Bob Pearson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210716174412.GA768036@nvidia.com \
--to=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearsonhpe@gmail.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox