[PATCH for-rc v3 0/6] RDMA/rxe: Various bug fixes.

Bob Pearson
2021-09-09T20:46:26Z

This series of patches implements several bug fixes and minor
cleanups of the rxe driver. Specifically these fix a bug exposed
by blktest.

They apply cleanly to both
commit 2169b908894df2ce83e7eb4a399d3224b2635126 (origin/for-rc, for-rc)
commit 6a217437f9f5482a3f6f2dc5fcd27cf0f62409ac (HEAD -> for-next,
origin/wip/jgg-for-next, origin/for-next, origin/HEAD)

These are being resubmitted to for-rc instead of for-next.

The v2 version had a typo which broke clean application to for-next.
Additionally in v3 the order of the patches was changed to make
it a little cleaner.

The first patch is a repeat of an earlier patch after rebasing.
It adds memory barriers to kernel to kernel queues. The logic for this
is the same as an earlier patch that only treated user to kernel queues.
Without this patch kernel to kernel queues are expected to intermittently
fail at low frequency as was seen for the other queues.

The second patch is also a repeat after rebasing. It fixes a multicast
bug.

The third patch cleans up the state and type enums used by MRs.

The fourth patch separates the keys in rxe_mr and ib_mr. This allows
the following sequence seen in the srp driver to work correctly.

do {
ib_post_send( IB_WR_LOCAL_INV )
ib_update_fast_reg_key()
ib_map_mr_sg()
ib_post_send( IB_WR_REG_MR )
} while ( !done )

The fifth patch creates duplicate mapping tables for fast MRs. This
prevents rkeys referencing fast MRs from accessing data from an updated
map after the call to ib_map_mr_sg() call by keeping the new and old
mappings separate and atomically swapping them when a reg mr WR is
executed.

The sixth patch checks the type of MRs which receive local or remote
invalidate operations to prevent invalidating user MRs.

Bob Pearson (6):
RDMA/rxe: Add memory barriers to kernel queues
RDMA/rxe: Fix memory allocation while locked
RDMA/rxe: Cleanup MR status and type enums
RDMA/rxe: Separate HW and SW l/rkeys
RDMA/rxe: Create duplicate mapping tables for FMRs
RDMA/rxe: Only allow invalidate for appropriate MRs

drivers/infiniband/sw/rxe/rxe_comp.c | 10 +-
drivers/infiniband/sw/rxe/rxe_cq.c | 25 +--
drivers/infiniband/sw/rxe/rxe_loc.h | 2 +
drivers/infiniband/sw/rxe/rxe_mcast.c | 2 +-
drivers/infiniband/sw/rxe/rxe_mr.c | 267 +++++++++++++++++++-------
drivers/infiniband/sw/rxe/rxe_mw.c | 36 ++--
drivers/infiniband/sw/rxe/rxe_qp.c | 10 +-
drivers/infiniband/sw/rxe/rxe_queue.h | 73 ++-----
drivers/infiniband/sw/rxe/rxe_req.c | 35 +---
drivers/infiniband/sw/rxe/rxe_resp.c | 38 +---
drivers/infiniband/sw/rxe/rxe_srq.c | 2 +-
drivers/infiniband/sw/rxe/rxe_verbs.c | 92 +++------
drivers/infiniband/sw/rxe/rxe_verbs.h | 48 ++---
13 files changed, 305 insertions(+), 335 deletions(-)

--
2.30.2