linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Bob Pearson <rpearsonhpe@gmail.com>
Cc: zyjzyj2000@gmail.com, linux-rdma@vger.kernel.org
Subject: Re: [PATCH for-next v4 0/6] Replace AV by AH in UD sends
Date: Tue, 5 Oct 2021 14:36:56 -0300	[thread overview]
Message-ID: <20211005173656.GA2664024@nvidia.com> (raw)
In-Reply-To: <20210930042603.4318-1-rpearsonhpe@gmail.com>

On Wed, Sep 29, 2021 at 11:25:58PM -0500, Bob Pearson wrote:
> Currently the rdma_rxe driver and its user space provider exchange
> addressing information for UD sends by having the provider compute an
> address vector (AV) and send it with each WQE. This is not the way
> that the RDMA verbs API was intended to operate.
> 
> This series of patches modifies the way UD send WQEs work by exchanging
> an index identifying the AH replacing the 88 byte AV by a 4 byte AH
> index. In order to not break compatibility with the existing API the
> rdma_rxe driver will recognise when an older version of the provider
> is not sending an index (i.e. it is 0) and will use the AV instead.
> 
> This series of patches is almost identical to an earlier version
> but rebased to 5.15.0-rc1+. It applies cleanly to
> 
>     450f4f6aa1a369cc3ffadc1c7e27dfab3e90199f (for-next)

It looks OK, but please rebase/resend it across Rao's patch to here:

commit 0994a1bcd5f7c0bf7ca3b4938d4f0f6928ac7886
Author: Rao Shoaib <Rao.Shoaib@oracle.com>
Date:   Tue Sep 14 18:12:20 2021 -0700

    RDMA/rxe: Bump up default maximum values used via uverbs
    
    In our internal testing we have found that default maximum values are too
    small.  Ideally there should be no limits, but since maximum values are
    reported via ibv_query_device, we have to return some value. So, the
    default maximums have been changed to large values.
    
    Link: https://lore.kernel.org/r/20210915011220.307585-1-Rao.Shoaib@oracle.com
    Signed-off-by: Rao Shoaib <Rao.Shoaib@oracle.com>
    Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>

Jason

      parent reply	other threads:[~2021-10-05 17:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-30  4:25 [PATCH for-next v4 0/6] Replace AV by AH in UD sends Bob Pearson
2021-09-30  4:25 ` [PATCH for-next v4 1/6] RDMA/rxe: Move AV from rxe_send_wqe to rxe_send_wr Bob Pearson
2021-09-30  4:26 ` [PATCH for-next v4 2/6] RDMA/rxe: Change AH objects to indexed Bob Pearson
2021-09-30  4:26 ` [PATCH for-next v4 3/6] RDMA/rxe: Create AH index and return to user space Bob Pearson
2021-09-30  4:26 ` [PATCH for-next v4 4/6] RDMA/rxe: Replace ah->pd by ah->ibah.pd Bob Pearson
2021-09-30  4:26 ` [PATCH for-next v4 5/6] RDMA/rxe: Lookup kernel AH from ah index in UD WQEs Bob Pearson
2021-09-30  4:26 ` [PATCH for-next v4 6/6] RDMA/rxe: Convert kernel UD post send to use ah_num Bob Pearson
2021-10-05 17:36 ` Jason Gunthorpe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211005173656.GA2664024@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=rpearsonhpe@gmail.com \
    --cc=zyjzyj2000@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).