* [PATCH v2 for-rc] RDMA/hns: Validate the pkey index
@ 2021-11-17 14:59 Kamal Heib
2021-11-17 20:54 ` Jason Gunthorpe
0 siblings, 1 reply; 2+ messages in thread
From: Kamal Heib @ 2021-11-17 14:59 UTC (permalink / raw)
To: linux-rdma; +Cc: Wenpeng Liang, Doug Ledford, Jason Gunthorpe, Kamal Heib
Before query pkey, make sure that the queried index is valid.
Fixes: 9a4435375cd1 ("IB/hns: Add driver files for hns RoCE driver")
Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
---
v2: Fix commit message.
---
drivers/infiniband/hw/hns/hns_roce_main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/infiniband/hw/hns/hns_roce_main.c b/drivers/infiniband/hw/hns/hns_roce_main.c
index 4194b626f3c6..8233bec053ee 100644
--- a/drivers/infiniband/hw/hns/hns_roce_main.c
+++ b/drivers/infiniband/hw/hns/hns_roce_main.c
@@ -270,6 +270,9 @@ static enum rdma_link_layer hns_roce_get_link_layer(struct ib_device *device,
static int hns_roce_query_pkey(struct ib_device *ib_dev, u32 port, u16 index,
u16 *pkey)
{
+ if (index > 0)
+ return -EINVAL;
+
*pkey = PKEY_ID;
return 0;
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 for-rc] RDMA/hns: Validate the pkey index
2021-11-17 14:59 [PATCH v2 for-rc] RDMA/hns: Validate the pkey index Kamal Heib
@ 2021-11-17 20:54 ` Jason Gunthorpe
0 siblings, 0 replies; 2+ messages in thread
From: Jason Gunthorpe @ 2021-11-17 20:54 UTC (permalink / raw)
To: Kamal Heib; +Cc: linux-rdma, Wenpeng Liang, Doug Ledford
On Wed, Nov 17, 2021 at 04:59:54PM +0200, Kamal Heib wrote:
> Before query pkey, make sure that the queried index is valid.
>
> Fixes: 9a4435375cd1 ("IB/hns: Add driver files for hns RoCE driver")
> Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
> ---
> v2: Fix commit message.
> ---
> drivers/infiniband/hw/hns/hns_roce_main.c | 3 +++
> 1 file changed, 3 insertions(+)
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-17 20:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-17 14:59 [PATCH v2 for-rc] RDMA/hns: Validate the pkey index Kamal Heib
2021-11-17 20:54 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).