From: Jason Gunthorpe <jgg@ziepe.ca>
To: Wenpeng Liang <liangwenpeng@huawei.com>
Cc: dledford@redhat.com, linux-rdma@vger.kernel.org, linuxarm@huawei.com
Subject: Re: [PATCH for-next 7/9] RDMA/hns: Add void conversion for function whose return value is not used
Date: Fri, 19 Nov 2021 13:28:30 -0400 [thread overview]
Message-ID: <20211119172830.GL876299@ziepe.ca> (raw)
In-Reply-To: <20211119140208.40416-8-liangwenpeng@huawei.com>
On Fri, Nov 19, 2021 at 10:02:06PM +0800, Wenpeng Liang wrote:
> From: Xinhao Liu <liuxinhao5@hisilicon.com>
>
> If the return value of the function is not used, then void should be
> added.
AFAIK we don't do this in the kernel
Jason
next prev parent reply other threads:[~2021-11-19 17:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 14:01 [PATCH for-next 0/9] RDMA/hns: Cleanup for clearing static warnings Wenpeng Liang
2021-11-19 14:02 ` [PATCH for-next 1/9] RDMA/hns: Correct the hex print format Wenpeng Liang
2021-11-19 14:02 ` [PATCH for-next 2/9] RDMA/hns: Correct the print format to be consistent with the variable type Wenpeng Liang
2021-11-19 14:02 ` [PATCH for-next 3/9] RDMA/hns: Replace tab with space in the right-side comments Wenpeng Liang
2021-11-19 14:02 ` [PATCH for-next 4/9] RDMA/hns: Correct the type of variables participating in the shift operation Wenpeng Liang
2021-11-19 14:02 ` [PATCH for-next 5/9] RDMA/hns: Initialize variable in the right place Wenpeng Liang
2021-11-19 17:27 ` Jason Gunthorpe
2021-11-24 4:01 ` Wenpeng Liang
2021-11-19 14:02 ` [PATCH for-next 6/9] RDMA/hns: Correctly initialize the members of Array[][] Wenpeng Liang
2021-11-19 14:02 ` [PATCH for-next 7/9] RDMA/hns: Add void conversion for function whose return value is not used Wenpeng Liang
2021-11-19 17:28 ` Jason Gunthorpe [this message]
2021-11-24 4:04 ` Wenpeng Liang
2021-11-19 14:02 ` [PATCH for-next 8/9] RDMA/hns: Remove macros that are no longer used Wenpeng Liang
2021-11-19 14:02 ` [PATCH for-next 9/9] RDMA/hns: Remove magic number Wenpeng Liang
2021-11-19 18:18 ` [PATCH for-next 0/9] RDMA/hns: Cleanup for clearing static warnings Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211119172830.GL876299@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dledford@redhat.com \
--cc=liangwenpeng@huawei.com \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).