From: Jason Gunthorpe <jgg@nvidia.com>
To: Bob Pearson <rpearsonhpe@gmail.com>
Cc: zyjzyj2000@gmail.com, linux-rdma@vger.kernel.org
Subject: Re: [PATCH for-next v4 09/13] RDMA/rxe: Replaced keyed rxe objects by indexed objects
Date: Fri, 19 Nov 2021 13:41:15 -0400 [thread overview]
Message-ID: <20211119174115.GB2988708@nvidia.com> (raw)
In-Reply-To: <20211103050241.61293-10-rpearsonhpe@gmail.com>
On Wed, Nov 03, 2021 at 12:02:38AM -0500, Bob Pearson wrote:
> + if (mgid->raw[10] == 0xff && mgid->raw[11] == 0xff) {
> + if ((mgid->raw[12] & 0xf0) != 0xe0)
> + pr_info("mgid is not an ipv4 mc address\n");
> +
> + /* mgid is a mapped IPV4 multicast address
> + * use the 32 bits as an index which will be
> + * unique
> + */
> + index = be32_to_cpu(val32[3]);
> + } else {
> + if (mgid->raw[0] != 0xff)
> + pr_info("mgid is not an ipv6 mc address\n");
> +
> + /* mgid is an IPV6 multicast address which won't
> + * fit into the index so construct the index
> + * from the four 32 bit words in mgid.
> + * If there is a collision treat it like
> + * no memory and return NULL
> + */
> + index = be32_to_cpu(val32[0] ^ val32[1]);
> + index = (index << 32) | be32_to_cpu(val32[2] ^ val32[3]);
I'm not sure failing is such a good thing, can it chain them on a
linked list or something?
Jason
next prev parent reply other threads:[~2021-11-19 17:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 5:02 [PATCH for-next v4 00/13] Correct race conditions in rdma_rxe Bob Pearson
2021-11-03 5:02 ` [PATCH for-next v4 01/13] RDMA/rxe: Replace irqsave locks with bh locks Bob Pearson
2021-11-03 5:02 ` [PATCH for-next v4 02/13] RDMA/rxe: Cleanup rxe_pool_entry Bob Pearson
2021-11-03 5:02 ` [PATCH for-next v4 03/13] RDMA/rxe: Copy setup parameters into rxe_pool Bob Pearson
2021-11-03 5:02 ` [PATCH for-next v4 04/13] RDMA/rxe: Save object pointer in pool element Bob Pearson
2021-11-03 5:02 ` [PATCH for-next v4 05/13] RDMA/rxe: Replace RB tree by xarray for indexes Bob Pearson
2021-11-19 17:38 ` Jason Gunthorpe
2021-11-03 5:02 ` [PATCH for-next v4 06/13] RDMA/rxe: Remove #include "rxe_loc.h" from rxe_pool.c Bob Pearson
2021-11-03 5:02 ` [PATCH v4 for-next 07/13] RDMA/rxe: Remove some #defines from rxe_pool.h Bob Pearson
2021-11-03 5:02 ` [PATCH v4 for-next 08/13] RDMA/rxe: Reverse the sense of RXE_POOL_NO_ALLOC Bob Pearson
2021-11-03 5:02 ` [PATCH for-next v4 09/13] RDMA/rxe: Replaced keyed rxe objects by indexed objects Bob Pearson
2021-11-19 17:41 ` Jason Gunthorpe [this message]
2021-11-30 19:35 ` Bob Pearson
2021-12-02 7:14 ` Christoph Lameter
2021-11-03 5:02 ` [PATCH for-next v4 10/13] RDMA/rxe: Prevent taking references to dead objects Bob Pearson
2021-11-19 17:45 ` Jason Gunthorpe
2021-11-30 20:05 ` Bob Pearson
2021-12-01 13:55 ` Jason Gunthorpe
2021-11-03 5:02 ` [PATCH for-next v4 11/13] RDMA/rxe: Fix ref error in rxe_av.c Bob Pearson
2021-11-03 5:02 ` [PATCH for-next v4 12/13] RDMA/rxe: Replace mr by rkey in responder resources Bob Pearson
2021-11-03 5:02 ` [PATCH for-next v4 13/13] RDMA/rxe: Protect against race between get_index and drop_ref Bob Pearson
2021-11-19 17:46 ` Jason Gunthorpe
2021-11-19 17:59 ` [PATCH for-next v4 00/13] Correct race conditions in rdma_rxe Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211119174115.GB2988708@nvidia.com \
--to=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearsonhpe@gmail.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).