From: Jason Gunthorpe <jgg@nvidia.com>
To: Bob Pearson <rpearsonhpe@gmail.com>
Cc: zyjzyj2000@gmail.com, linux-rdma@vger.kernel.org
Subject: Re: [PATCH for-next v4 00/13] Correct race conditions in rdma_rxe
Date: Fri, 19 Nov 2021 13:59:13 -0400 [thread overview]
Message-ID: <20211119175913.GA2994898@nvidia.com> (raw)
In-Reply-To: <20211103050241.61293-1-rpearsonhpe@gmail.com>
On Wed, Nov 03, 2021 at 12:02:29AM -0500, Bob Pearson wrote:
> There are several race conditions discovered in the current rdma_rxe
> driver. They mostly relate to races between normal operations and
> destroying objects. This patch series makes several minor cleanups in
> rxe_pool.[ch] and replaces the red-black trees currently used by xarrays
> which have better atomic behavior.
>
> This patch series applies cleanly to current for-next.
> commit 6a463bc9d999 ("Merge branch 'for-rc' into rdma.git for-next")
>
> Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com>
> v4
> Restructured patch series to change to xarray earlier which
> greatly simplified the changes.
> Rebased to current for-next
> v3
> Changed rxe_alloc to use GFP_KERNEL
> Addressed other comments by Jason Gunthorp
> Merged the previous 06/10 and 07/10 patches into one since they overlapped
> Added some minor cleanups as 10/10
> v2
> Rebased to current for-next.
> Added 4 additional patches
>
> Bob Pearson (13):
> RDMA/rxe: Replace irqsave locks with bh locks
> RDMA/rxe: Cleanup rxe_pool_entry
> RDMA/rxe: Copy setup parameters into rxe_pool
> RDMA/rxe: Save object pointer in pool element
> RDMA/rxe: Remove #include "rxe_loc.h" from rxe_pool.c
I took these patches
> RDMA/rxe: Replace RB tree by xarray for indexes
> RDMA/rxe: Remove some #defines from rxe_pool.h
> RDMA/rxe: Reverse the sense of RXE_POOL_NO_ALLOC
> RDMA/rxe: Replaced keyed rxe objects by indexed objects
> RDMA/rxe: Prevent taking references to dead objects
> RDMA/rxe: Fix ref error in rxe_av.c
> RDMA/rxe: Replace mr by rkey in responder resources
> RDMA/rxe: Protect against race between get_index and drop_ref
These need some fixing
Thanks,
Jason
prev parent reply other threads:[~2021-11-19 17:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 5:02 [PATCH for-next v4 00/13] Correct race conditions in rdma_rxe Bob Pearson
2021-11-03 5:02 ` [PATCH for-next v4 01/13] RDMA/rxe: Replace irqsave locks with bh locks Bob Pearson
2021-11-03 5:02 ` [PATCH for-next v4 02/13] RDMA/rxe: Cleanup rxe_pool_entry Bob Pearson
2021-11-03 5:02 ` [PATCH for-next v4 03/13] RDMA/rxe: Copy setup parameters into rxe_pool Bob Pearson
2021-11-03 5:02 ` [PATCH for-next v4 04/13] RDMA/rxe: Save object pointer in pool element Bob Pearson
2021-11-03 5:02 ` [PATCH for-next v4 05/13] RDMA/rxe: Replace RB tree by xarray for indexes Bob Pearson
2021-11-19 17:38 ` Jason Gunthorpe
2021-11-03 5:02 ` [PATCH for-next v4 06/13] RDMA/rxe: Remove #include "rxe_loc.h" from rxe_pool.c Bob Pearson
2021-11-03 5:02 ` [PATCH v4 for-next 07/13] RDMA/rxe: Remove some #defines from rxe_pool.h Bob Pearson
2021-11-03 5:02 ` [PATCH v4 for-next 08/13] RDMA/rxe: Reverse the sense of RXE_POOL_NO_ALLOC Bob Pearson
2021-11-03 5:02 ` [PATCH for-next v4 09/13] RDMA/rxe: Replaced keyed rxe objects by indexed objects Bob Pearson
2021-11-19 17:41 ` Jason Gunthorpe
2021-11-30 19:35 ` Bob Pearson
2021-12-02 7:14 ` Christoph Lameter
2021-11-03 5:02 ` [PATCH for-next v4 10/13] RDMA/rxe: Prevent taking references to dead objects Bob Pearson
2021-11-19 17:45 ` Jason Gunthorpe
2021-11-30 20:05 ` Bob Pearson
2021-12-01 13:55 ` Jason Gunthorpe
2021-11-03 5:02 ` [PATCH for-next v4 11/13] RDMA/rxe: Fix ref error in rxe_av.c Bob Pearson
2021-11-03 5:02 ` [PATCH for-next v4 12/13] RDMA/rxe: Replace mr by rkey in responder resources Bob Pearson
2021-11-03 5:02 ` [PATCH for-next v4 13/13] RDMA/rxe: Protect against race between get_index and drop_ref Bob Pearson
2021-11-19 17:46 ` Jason Gunthorpe
2021-11-19 17:59 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211119175913.GA2994898@nvidia.com \
--to=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearsonhpe@gmail.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).