From: "hch@lst.de" <hch@lst.de>
To: Ira Weiny <ira.weiny@intel.com>
Cc: "hch@lst.de" <hch@lst.de>,
"yangx.jy@fujitsu.com" <yangx.jy@fujitsu.com>,
Jason Gunthorpe <jgg@nvidia.com>,
"lizhijian@fujitsu.com" <lizhijian@fujitsu.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"tom@talpey.com" <tom@talpey.com>,
"yanjun.zhu@linux.dev" <yanjun.zhu@linux.dev>,
"rpearsonhpe@gmail.com" <rpearsonhpe@gmail.com>,
"y-goto@fujitsu.com" <y-goto@fujitsu.com>,
"tomasz.gromadzki@intel.com" <tomasz.gromadzki@intel.com>
Subject: Re: [RFC PATCH v2 2/2] RDMA/rxe: Support RDMA Atomic Write operation
Date: Fri, 28 Jan 2022 07:16:18 +0100 [thread overview]
Message-ID: <20220128061618.GA1551@lst.de> (raw)
In-Reply-To: <20220127180833.GF785175@iweiny-DESK2.sc.intel.com>
On Thu, Jan 27, 2022 at 10:08:33AM -0800, Ira Weiny wrote:
> On Thu, Jan 27, 2022 at 10:57:30AM +0100, Christoph Hellwig wrote:
> > On Thu, Jan 27, 2022 at 09:37:59AM +0000, yangx.jy@fujitsu.com wrote:
> > > Do you mean we have to consider that some allocated pages come from high
> > > memory?
> > >
> > > I think INFINIBAND_VIRT_DMA kconfig[1] has ensured that all allocated
> > > pages have a kernel virtual address.
> >
> > rxe and siw depend on INFINIBAND_VIRT_DMA which depends on !HIGHMEM,
> > so you don't need kmap here at all.
>
> Until/if I get PKS protecting pmem.[1] Then if the page is pmem, page_address()
> will give you an address which you will fault on when you access it.
In that case we'll have problems all over the drivers that select
INFINIBAND_VIRT_DMA, so this one doesn't make much of a difference..
next prev parent reply other threads:[~2022-01-28 6:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 3:03 [RFC PATCH v2 0/2] RDMA/rxe: Add RDMA Atomic Write operation Xiao Yang
2022-01-13 3:03 ` [RFC PATCH v2 1/2] RDMA/rxe: Rename send_atomic_ack() and atomic member of struct resp_res Xiao Yang
2022-01-13 3:03 ` [RFC PATCH v2 2/2] RDMA/rxe: Support RDMA Atomic Write operation Xiao Yang
2022-01-17 13:16 ` Jason Gunthorpe
2022-01-18 8:01 ` yangx.jy
2022-01-18 12:35 ` Jason Gunthorpe
2022-01-19 1:54 ` lizhijian
2022-01-19 12:36 ` Jason Gunthorpe
2022-01-19 16:47 ` Ira Weiny
2022-01-20 12:07 ` Li, Zhijian
2022-01-21 12:58 ` Jason Gunthorpe
2022-01-21 16:06 ` Ira Weiny
2022-01-21 16:08 ` Ira Weiny
2022-01-24 3:47 ` lizhijian
2022-01-27 9:37 ` yangx.jy
2022-01-27 9:57 ` hch
2022-01-27 18:08 ` Ira Weiny
2022-01-28 6:16 ` hch [this message]
2022-01-28 19:15 ` Ira Weiny
2022-02-10 11:06 ` yangx.jy
2022-02-11 18:30 ` Ira Weiny
2022-01-18 8:02 ` yangx.jy
2022-01-18 8:04 ` yangx.jy
2022-01-18 9:03 ` yangx.jy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220128061618.GA1551@lst.de \
--to=hch@lst.de \
--cc=ira.weiny@intel.com \
--cc=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
--cc=rpearsonhpe@gmail.com \
--cc=tom@talpey.com \
--cc=tomasz.gromadzki@intel.com \
--cc=y-goto@fujitsu.com \
--cc=yangx.jy@fujitsu.com \
--cc=yanjun.zhu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).