* [PATCH rdma-next] RDMA/mlx5: Delete get_num_static_uars function
@ 2022-01-23 18:00 Leon Romanovsky
2022-01-28 17:05 ` Jason Gunthorpe
0 siblings, 1 reply; 2+ messages in thread
From: Leon Romanovsky @ 2022-01-23 18:00 UTC (permalink / raw)
To: Jason Gunthorpe; +Cc: Leon Romanovsky, linux-kernel, linux-rdma
From: Leon Romanovsky <leonro@nvidia.com>
There is no need to keep get_num_static_uars in the headers file
as it is not shared and used only once.
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
---
drivers/infiniband/hw/mlx5/mlx5_ib.h | 6 ------
drivers/infiniband/hw/mlx5/qp.c | 3 ++-
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/infiniband/hw/mlx5/mlx5_ib.h b/drivers/infiniband/hw/mlx5/mlx5_ib.h
index 357bcf4e305d..104acd986c66 100644
--- a/drivers/infiniband/hw/mlx5/mlx5_ib.h
+++ b/drivers/infiniband/hw/mlx5/mlx5_ib.h
@@ -1526,12 +1526,6 @@ static inline int get_uars_per_sys_page(struct mlx5_ib_dev *dev, bool lib_suppor
MLX5_UARS_IN_PAGE : 1;
}
-static inline int get_num_static_uars(struct mlx5_ib_dev *dev,
- struct mlx5_bfreg_info *bfregi)
-{
- return get_uars_per_sys_page(dev, bfregi->lib_uar_4k) * bfregi->num_static_sys_pages;
-}
-
extern void *xlt_emergency_page;
int bfregn_to_uar_index(struct mlx5_ib_dev *dev,
diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
index bf0a0ef380d4..4f325a844c93 100644
--- a/drivers/infiniband/hw/mlx5/qp.c
+++ b/drivers/infiniband/hw/mlx5/qp.c
@@ -615,7 +615,8 @@ enum {
static int max_bfregs(struct mlx5_ib_dev *dev, struct mlx5_bfreg_info *bfregi)
{
- return get_num_static_uars(dev, bfregi) * MLX5_NON_FP_BFREGS_PER_UAR;
+ return get_uars_per_sys_page(dev, bfregi->lib_uar_4k) *
+ bfregi->num_static_sys_pages * MLX5_NON_FP_BFREGS_PER_UAR;
}
static int num_med_bfreg(struct mlx5_ib_dev *dev,
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH rdma-next] RDMA/mlx5: Delete get_num_static_uars function
2022-01-23 18:00 [PATCH rdma-next] RDMA/mlx5: Delete get_num_static_uars function Leon Romanovsky
@ 2022-01-28 17:05 ` Jason Gunthorpe
0 siblings, 0 replies; 2+ messages in thread
From: Jason Gunthorpe @ 2022-01-28 17:05 UTC (permalink / raw)
To: Leon Romanovsky; +Cc: Leon Romanovsky, linux-kernel, linux-rdma
On Sun, Jan 23, 2022 at 08:00:48PM +0200, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
>
> There is no need to keep get_num_static_uars in the headers file
> as it is not shared and used only once.
>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> ---
> drivers/infiniband/hw/mlx5/mlx5_ib.h | 6 ------
> drivers/infiniband/hw/mlx5/qp.c | 3 ++-
> 2 files changed, 2 insertions(+), 7 deletions(-)
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-28 17:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-23 18:00 [PATCH rdma-next] RDMA/mlx5: Delete get_num_static_uars function Leon Romanovsky
2022-01-28 17:05 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).