From: Jason Gunthorpe <jgg@nvidia.com>
To: mike.marciniszyn@cornelisnetworks.com
Cc: linux-rdma@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH for-rc] IB/qib: Fix duplicate sysfs directory name
Date: Fri, 18 Feb 2022 11:57:07 -0400 [thread overview]
Message-ID: <20220218155707.GA1583594@nvidia.com> (raw)
In-Reply-To: <1645106372-23004-1-git-send-email-mike.marciniszyn@cornelisnetworks.com>
On Thu, Feb 17, 2022 at 08:59:32AM -0500, mike.marciniszyn@cornelisnetworks.com wrote:
> From: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
>
> The qib driver load has been failing with the
> following message:
>
> [ 21.186138] sysfs: cannot create duplicate filename '/devices/pci0000:80/0000:80:02.0/0000:81:00.0/infiniband/qib0/ports/1/linkcontrol'
>
> The patch below has two "linkcontrol" names causing the duplication.
>
> Fix by using the correct "diag_counters" name on the second instance.
>
> Fixes: 4a7aaf88c89f ("RDMA/qib: Use attributes for the port sysfs")
> Cc: <stable@vger.kernel.org>
> Reviewed-by: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
> Signed-off-by: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
> ---
> drivers/infiniband/hw/qib/qib_sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-rc, thanks
Jason
prev parent reply other threads:[~2022-02-18 15:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 13:59 [PATCH for-rc] IB/qib: Fix duplicate sysfs directory name mike.marciniszyn
2022-02-18 15:57 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220218155707.GA1583594@nvidia.com \
--to=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@cornelisnetworks.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).