From: Bob Pearson <rpearsonhpe@gmail.com>
To: jgg@nvidia.com, zyjzyj2000@gmail.com, linux-rdma@vger.kernel.org
Cc: Bob Pearson <rpearsonhpe@gmail.com>
Subject: [PATCH for-next v10 00/11] Fix race conditions in rxe_pool
Date: Fri, 25 Feb 2022 13:57:40 -0600 [thread overview]
Message-ID: <20220225195750.37802-1-rpearsonhpe@gmail.com> (raw)
There are several race conditions discovered in the current rdma_rxe
driver. They mostly relate to races between normal operations and
destroying objects. This patch series
- Makes several minor cleanups in rxe_pool.[ch]
- Replaces the red-black trees currently used by xarrays for indices
- Corrects several reference counting errors
- Adds wait for completions to the paths in verbs APIs which destroy
objects.
- Changes read side locking to rcu.
Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com>
---
v10
Rebased to current wip/jgg-for-next.
Split some patches into smaller ones.
v9
Corrected issues reported by Jason Gunthorpe,
Converted locking in rxe_mcast.c and rxe_pool.c to use RCU
Split up the patches into smaller changes
v8
Fixed an additional race in 3/8 which was not handled correctly.
v7
Corrected issues reported by Jason Gunthorpe
Link: https://lore.kernel.org/linux-rdma/20211207190947.GH6385@nvidia.com/
Link: https://lore.kernel.org/linux-rdma/20211207191857.GI6385@nvidia.com/
Link: https://lore.kernel.org/linux-rdma/20211207192824.GJ6385@nvidia.com/
v6
Fixed a kzalloc flags bug.
Fixed comment bug reported by 'Kernel Test Robot'.
Changed type of rxe_pool.c in __rxe_fini().
v5
Removed patches already accepted into for-next and addressed comments
from Jason Gunthorpe.
v4
Restructured patch series to change to xarray earlier which
greatly simplified the changes.
Rebased to current for-next
v3
Changed rxe_alloc to use GFP_KERNEL
Addressed other comments by Jason Gunthorp
Merged the previous 06/10 and 07/10 patches into one since they overlapped
Added some minor cleanups as 10/10
v2
Rebased to current for-next.
Added 4 additional patches
Bob Pearson (11):
RDMA/rxe: Reverse the sense of RXE_POOL_NO_ALLOC
RDMA/rxe: Delete _locked() APIs for pool objects
RDMA/rxe: Replace obj by elem in declaration
RDMA/rxe: Replace red-black trees by xarrays
RDMA/rxe: Stop lookup of partially built objects
RDMA/rxe: Add wait_for_completion to pool objects
RDMA/rxe: Fix ref error in rxe_av.c
RDMA/rxe: Replace mr by rkey in responder resources
RDMA/rxe: Convert read side locking to rcu
RDMA/rxe: Move max_elem into rxe_type_info
RDMA/rxe: Cleanup rxe_pool.c
drivers/infiniband/sw/rxe/rxe.c | 87 +----
drivers/infiniband/sw/rxe/rxe_av.c | 19 +-
drivers/infiniband/sw/rxe/rxe_loc.h | 5 +-
drivers/infiniband/sw/rxe/rxe_mr.c | 4 +-
drivers/infiniband/sw/rxe/rxe_mw.c | 13 +-
drivers/infiniband/sw/rxe/rxe_net.c | 17 +-
drivers/infiniband/sw/rxe/rxe_pool.c | 453 ++++++++++++++------------
drivers/infiniband/sw/rxe/rxe_pool.h | 74 ++---
drivers/infiniband/sw/rxe/rxe_qp.c | 10 +-
drivers/infiniband/sw/rxe/rxe_req.c | 55 ++--
drivers/infiniband/sw/rxe/rxe_resp.c | 125 ++++---
drivers/infiniband/sw/rxe/rxe_verbs.c | 55 ++--
drivers/infiniband/sw/rxe/rxe_verbs.h | 1 -
13 files changed, 462 insertions(+), 456 deletions(-)
base-commit: 3ac3107872b8dd4b5c4c1b598fcbc24983cd009b
Patch applies to current wip/jgg-for-next with or without the last
two (5-6/6) patches in the multicast series.
--
2.32.0
next reply other threads:[~2022-02-25 19:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 19:57 Bob Pearson [this message]
2022-02-25 19:57 ` [PATCH for-next v10 01/11] RDMA/rxe: Reverse the sense of RXE_POOL_NO_ALLOC Bob Pearson
2022-02-28 17:15 ` Jason Gunthorpe
2022-02-25 19:57 ` [PATCH for-next v10 02/11] RDMA/rxe: Delete _locked() APIs for pool objects Bob Pearson
2022-02-25 19:57 ` [PATCH for-next v10 03/11] RDMA/rxe: Replace obj by elem in declaration Bob Pearson
2022-02-25 19:57 ` [PATCH for-next v10 04/11] RDMA/rxe: Replace red-black trees by xarrays Bob Pearson
2022-02-28 16:57 ` Jason Gunthorpe
2022-02-28 17:28 ` Robert Pearson
2022-02-28 17:56 ` Jason Gunthorpe
2022-02-25 19:57 ` [PATCH for-next v10 05/11] RDMA/rxe: Stop lookup of partially built objects Bob Pearson
2022-02-28 17:01 ` Jason Gunthorpe
2022-02-25 19:57 ` [PATCH for-next v10 06/11] RDMA/rxe: Add wait_for_completion to pool objects Bob Pearson
2022-02-28 17:05 ` Jason Gunthorpe
2022-02-25 19:57 ` [PATCH for-next v10 07/11] RDMA/rxe: Fix ref error in rxe_av.c Bob Pearson
2022-02-28 17:06 ` Jason Gunthorpe
2022-02-25 19:57 ` [PATCH for-next v10 08/11] RDMA/rxe: Replace mr by rkey in responder resources Bob Pearson
2022-02-25 19:57 ` [PATCH for-next v10 09/11] RDMA/rxe: Convert read side locking to rcu Bob Pearson
2022-02-28 17:12 ` Jason Gunthorpe
2022-02-25 19:57 ` [PATCH for-next v10 10/11] RDMA/rxe: Move max_elem into rxe_type_info Bob Pearson
2022-02-25 19:57 ` [PATCH for-next v10 11/11] RDMA/rxe: Cleanup rxe_pool.c Bob Pearson
2022-02-25 20:46 ` [PATCH for-next v10 00/11] Fix race conditions in rxe_pool Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220225195750.37802-1-rpearsonhpe@gmail.com \
--to=rpearsonhpe@gmail.com \
--cc=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).