From: Jason Gunthorpe <jgg@nvidia.com>
To: Bob Pearson <rpearsonhpe@gmail.com>
Cc: zyjzyj2000@gmail.com, linux-rdma@vger.kernel.org
Subject: Re: [PATCH for-next v10 07/11] RDMA/rxe: Fix ref error in rxe_av.c
Date: Mon, 28 Feb 2022 13:06:27 -0400 [thread overview]
Message-ID: <20220228170627.GL219866@nvidia.com> (raw)
In-Reply-To: <20220225195750.37802-8-rpearsonhpe@gmail.com>
On Fri, Feb 25, 2022 at 01:57:47PM -0600, Bob Pearson wrote:
> The commit referenced below can take a reference to the AH which is
> never dropped. This only happens in the UD request path. This patch
> optionally passes that AH back to the caller so that it can hold the
> reference while the AV is being accessed and then drop it. Code to
> do this is added to rxe_req.c. The AV is also passed to rxe_prepare
> in rxe_net.c as an optimization.
>
> Fixes: e2fe06c90806 ("RDMA/rxe: Lookup kernel AH from ah index in UD WQEs")
> Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com>
> ---
> drivers/infiniband/sw/rxe/rxe_av.c | 19 +++++++++-
> drivers/infiniband/sw/rxe/rxe_loc.h | 5 ++-
> drivers/infiniband/sw/rxe/rxe_net.c | 17 +++++----
> drivers/infiniband/sw/rxe/rxe_req.c | 55 +++++++++++++++++-----------
> drivers/infiniband/sw/rxe/rxe_resp.c | 2 +-
> 5 files changed, 63 insertions(+), 35 deletions(-)
This should be ordered earlier as the prior patch turns this into a
bigger problem?
Jason
next prev parent reply other threads:[~2022-02-28 17:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 19:57 [PATCH for-next v10 00/11] Fix race conditions in rxe_pool Bob Pearson
2022-02-25 19:57 ` [PATCH for-next v10 01/11] RDMA/rxe: Reverse the sense of RXE_POOL_NO_ALLOC Bob Pearson
2022-02-28 17:15 ` Jason Gunthorpe
2022-02-25 19:57 ` [PATCH for-next v10 02/11] RDMA/rxe: Delete _locked() APIs for pool objects Bob Pearson
2022-02-25 19:57 ` [PATCH for-next v10 03/11] RDMA/rxe: Replace obj by elem in declaration Bob Pearson
2022-02-25 19:57 ` [PATCH for-next v10 04/11] RDMA/rxe: Replace red-black trees by xarrays Bob Pearson
2022-02-28 16:57 ` Jason Gunthorpe
2022-02-28 17:28 ` Robert Pearson
2022-02-28 17:56 ` Jason Gunthorpe
2022-02-25 19:57 ` [PATCH for-next v10 05/11] RDMA/rxe: Stop lookup of partially built objects Bob Pearson
2022-02-28 17:01 ` Jason Gunthorpe
2022-02-25 19:57 ` [PATCH for-next v10 06/11] RDMA/rxe: Add wait_for_completion to pool objects Bob Pearson
2022-02-28 17:05 ` Jason Gunthorpe
2022-02-25 19:57 ` [PATCH for-next v10 07/11] RDMA/rxe: Fix ref error in rxe_av.c Bob Pearson
2022-02-28 17:06 ` Jason Gunthorpe [this message]
2022-02-25 19:57 ` [PATCH for-next v10 08/11] RDMA/rxe: Replace mr by rkey in responder resources Bob Pearson
2022-02-25 19:57 ` [PATCH for-next v10 09/11] RDMA/rxe: Convert read side locking to rcu Bob Pearson
2022-02-28 17:12 ` Jason Gunthorpe
2022-02-25 19:57 ` [PATCH for-next v10 10/11] RDMA/rxe: Move max_elem into rxe_type_info Bob Pearson
2022-02-25 19:57 ` [PATCH for-next v10 11/11] RDMA/rxe: Cleanup rxe_pool.c Bob Pearson
2022-02-25 20:46 ` [PATCH for-next v10 00/11] Fix race conditions in rxe_pool Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220228170627.GL219866@nvidia.com \
--to=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearsonhpe@gmail.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).