From: Saeed Mahameed <saeed@kernel.org>
To: Joe Damato <jdamato@fastly.com>
Cc: netdev@vger.kernel.org, kuba@kernel.org,
ilias.apalodimas@linaro.org, davem@davemloft.net,
hawk@kernel.org, ttoukan.linux@gmail.com, brouer@redhat.com,
leon@kernel.org, linux-rdma@vger.kernel.org, saeedm@nvidia.com
Subject: Re: [net-next v8 1/4] page_pool: Add allocation stats
Date: Tue, 1 Mar 2022 15:50:31 -0800 [thread overview]
Message-ID: <20220301235031.ryy4trywlc3bmnpx@sx1> (raw)
In-Reply-To: <1646172610-129397-2-git-send-email-jdamato@fastly.com>
On 01 Mar 14:10, Joe Damato wrote:
>Add per-pool statistics counters for the allocation path of a page pool.
>These stats are incremented in softirq context, so no locking or per-cpu
>variables are needed.
>
>This code is disabled by default and a kernel config option is provided for
>users who wish to enable them.
>
Sorry for the late review Joe,
Why disabled by default ? if your benchmarks showed no diff.
IMHO If we believe in this, we should have it enabled by default.
>The statistics added are:
> - fast: successful fast path allocations
> - slow: slow path order-0 allocations
> - slow_high_order: slow path high order allocations
> - empty: ptr ring is empty, so a slow path allocation was forced.
> - refill: an allocation which triggered a refill of the cache
> - waive: pages obtained from the ptr ring that cannot be added to
> the cache due to a NUMA mismatch.
>
Let's have this documented under kernel documentation.
https://docs.kernel.org/networking/page_pool.html
I would also mention the kconfig and any user knobs APIs introduced in
this series
next prev parent reply other threads:[~2022-03-01 23:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 22:10 [net-next v8 0/4] page_pool: Add stats counters Joe Damato
2022-03-01 22:10 ` [net-next v8 1/4] page_pool: Add allocation stats Joe Damato
2022-03-01 23:50 ` Saeed Mahameed [this message]
2022-03-02 1:51 ` Joe Damato
2022-03-02 4:32 ` Saeed Mahameed
2022-03-01 22:10 ` [net-next v8 2/4] page_pool: Add recycle stats Joe Damato
2022-03-01 23:58 ` Saeed Mahameed
2022-03-01 22:10 ` [net-next v8 3/4] page_pool: Add function to batch and return stats Joe Damato
2022-03-01 22:10 ` [net-next v8 4/4] mlx5: add support for page_pool_get_stats Joe Damato
2022-03-02 1:02 ` Saeed Mahameed
2022-03-02 1:50 ` Joe Damato
2022-03-02 4:36 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220301235031.ryy4trywlc3bmnpx@sx1 \
--to=saeed@kernel.org \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=jdamato@fastly.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
--cc=ttoukan.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox