From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-rdma-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id A7FF4C433F5
	for <linux-rdma@archiver.kernel.org>; Tue,  1 Mar 2022 23:58:15 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233206AbiCAX6z (ORCPT <rfc822;linux-rdma@archiver.kernel.org>);
        Tue, 1 Mar 2022 18:58:55 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45000 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S232698AbiCAX6z (ORCPT
        <rfc822;linux-rdma@vger.kernel.org>); Tue, 1 Mar 2022 18:58:55 -0500
Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E7B88BF1D;
        Tue,  1 Mar 2022 15:58:13 -0800 (PST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by dfw.source.kernel.org (Postfix) with ESMTPS id EE5EB6140C;
        Tue,  1 Mar 2022 23:58:12 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0F726C340EE;
        Tue,  1 Mar 2022 23:58:11 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1646179092;
        bh=KWv76Q2EMIsDVyxOr1ybYw+y0edCn8cbbmznG253gHs=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=H5HpHnatIv4ATBKw3ik8xbQNnT+O7aCi0jUXoTrP5w8wtOxDk4mwFzvDRP+QlCODF
         i2+H+UMnhKrN4fmj0U1E/hqouxLZiFQY8j+lMRhSIYuneNUYOcFhOByzPbmWegLVAE
         opO91k8GhZNo0zkrslHs0kSe7pwCTx2No8/9Y6fEbjM0OsESDuzL2aNvmW5jrzIJDf
         aQxhlsr2fMBK+SlLH0y4jIe84eRkhK5BK9LfRK7QzUPFKSDG5q7kJtxcnlt5Bsu8vt
         ZvRgJYh+rlJIWzvBH5ta4s5fa65nRnxqrE6+4lRWz7D6mcQaUFHjo0RmaKrKcIoMFf
         fgmAcibytKFyA==
Date:   Tue, 1 Mar 2022 15:58:10 -0800
From:   Saeed Mahameed <saeed@kernel.org>
To:     Joe Damato <jdamato@fastly.com>
Cc:     netdev@vger.kernel.org, kuba@kernel.org,
        ilias.apalodimas@linaro.org, davem@davemloft.net, hawk@kernel.org,
        ttoukan.linux@gmail.com, brouer@redhat.com, leon@kernel.org,
        linux-rdma@vger.kernel.org, saeedm@nvidia.com
Subject: Re: [net-next v8 2/4] page_pool: Add recycle stats
Message-ID: <20220301235810.ywhifu27sbco67bd@sx1>
References: <1646172610-129397-1-git-send-email-jdamato@fastly.com>
 <1646172610-129397-3-git-send-email-jdamato@fastly.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <1646172610-129397-3-git-send-email-jdamato@fastly.com>
Precedence: bulk
List-ID: <linux-rdma.vger.kernel.org>
X-Mailing-List: linux-rdma@vger.kernel.org

On 01 Mar 14:10, Joe Damato wrote:
>Add per-cpu stats tracking page pool recycling events:
>	- cached: recycling placed page in the page pool cache
>	- cache_full: page pool cache was full
>	- ring: page placed into the ptr ring
>	- ring_full: page released from page pool because the ptr ring was full
>	- released_refcnt: page released (and not recycled) because refcnt > 1
>

Kernel documentation.

[...]

>
>@@ -410,6 +423,11 @@ static bool page_pool_recycle_in_ring(struct page_pool *pool, struct page *page)
> 	else
> 		ret = ptr_ring_produce_bh(&pool->ring, page);
>
>+#ifdef CONFIG_PAGE_POOL_STATS
>+	if (ret == 0)
>+		recycle_stat_inc(pool, ring);
>+#endif
>+
> 	return (ret == 0) ? true : false;
> }
>

To avoid the ifdef, it makes more sense to refactor to:

if (!ret) {
	recycle_stat_inc(pool, ring);
         return true;
}

return false;