From: Chengguang Xu <cgxu519@mykernel.net>
To: zyjzyj2000@gmail.com, jgg@ziepe.ca
Cc: leon@kernel.org, linux-rdma@vger.kernel.org,
Chengguang Xu <cgxu519@mykernel.net>
Subject: [PATCH v2 1/2] RDMA/rxe: change variable and function argument to proper type
Date: Mon, 7 Mar 2022 22:50:46 +0800 [thread overview]
Message-ID: <20220307145047.3235675-1-cgxu519@mykernel.net> (raw)
The type of wqe length is u32 so in order to avoid overflow
and shadow casting change variable and relevant function argument to
proper type.
Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
---
drivers/infiniband/sw/rxe/rxe_req.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/infiniband/sw/rxe/rxe_req.c b/drivers/infiniband/sw/rxe/rxe_req.c
index 5eb89052dd66..b28036a7a3b8 100644
--- a/drivers/infiniband/sw/rxe/rxe_req.c
+++ b/drivers/infiniband/sw/rxe/rxe_req.c
@@ -359,7 +359,7 @@ static inline int get_mtu(struct rxe_qp *qp)
static struct sk_buff *init_req_packet(struct rxe_qp *qp,
struct rxe_send_wqe *wqe,
- int opcode, int payload,
+ int opcode, u32 payload,
struct rxe_pkt_info *pkt)
{
struct rxe_dev *rxe = to_rdev(qp->ibqp.device);
@@ -449,7 +449,7 @@ static struct sk_buff *init_req_packet(struct rxe_qp *qp,
static int finish_packet(struct rxe_qp *qp, struct rxe_send_wqe *wqe,
struct rxe_pkt_info *pkt, struct sk_buff *skb,
- int paylen)
+ u32 paylen)
{
int err;
@@ -497,7 +497,7 @@ static void update_wqe_state(struct rxe_qp *qp,
static void update_wqe_psn(struct rxe_qp *qp,
struct rxe_send_wqe *wqe,
struct rxe_pkt_info *pkt,
- int payload)
+ u32 payload)
{
/* number of packets left to send including current one */
int num_pkt = (wqe->dma.resid + payload + qp->mtu - 1) / qp->mtu;
@@ -540,7 +540,7 @@ static void rollback_state(struct rxe_send_wqe *wqe,
}
static void update_state(struct rxe_qp *qp, struct rxe_send_wqe *wqe,
- struct rxe_pkt_info *pkt, int payload)
+ struct rxe_pkt_info *pkt, u32 payload)
{
qp->req.opcode = pkt->opcode;
@@ -612,7 +612,7 @@ int rxe_requester(void *arg)
struct sk_buff *skb;
struct rxe_send_wqe *wqe;
enum rxe_hdr_mask mask;
- int payload;
+ u32 payload;
int mtu;
int opcode;
int ret;
--
2.27.0
next reply other threads:[~2022-03-07 14:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 14:50 Chengguang Xu [this message]
2022-03-07 14:50 ` [PATCH v2 2/2] RDMA/rxe: remove useless argument for update_state() Chengguang Xu
2022-03-09 13:34 ` Leon Romanovsky
2022-03-10 2:32 ` Zhu Yanjun
2022-03-09 13:34 ` [PATCH v2 1/2] RDMA/rxe: change variable and function argument to proper type Leon Romanovsky
2022-03-14 23:44 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220307145047.3235675-1-cgxu519@mykernel.net \
--to=cgxu519@mykernel.net \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox