From: Jason Gunthorpe <jgg@nvidia.com>
To: Bob Pearson <rpearsonhpe@gmail.com>
Cc: zyjzyj2000@gmail.com, linux-rdma@vger.kernel.org
Subject: Re: [PATCH for-next v2] RDMA/rxe: Fix "Replace mr by rkey in responder resources"
Date: Wed, 20 Apr 2022 12:53:12 -0300 [thread overview]
Message-ID: <20220420155312.GA1432137@nvidia.com> (raw)
In-Reply-To: <20220418174103.3040-1-rpearsonhpe@gmail.com>
On Mon, Apr 18, 2022 at 12:41:04PM -0500, Bob Pearson wrote:
> The rping benchmark fails on long runs. The root cause of this
> failure has been traced to a failure to compute a nonzero value of mr
> in rare situations.
>
> Fix this failure by correctly handling the computation of mr in
> read_reply() in rxe_resp.c in the replay flow.
>
> Fixes: 8a1a0be894da ("RDMA/rxe: Replace mr by rkey in responder resources")
> Link: https://lore.kernel.org/linux-rdma/1a9a9190-368d-3442-0a62-443b1a6c1209@linux.dev/
> Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com>
> ---
> v2
> Renamed commit
> Changed fixes line to correctly ID the bug
> Added a link to the reported mr == NULL issue
>
> drivers/infiniband/sw/rxe/rxe_resp.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
Applied to for-rc, thanks
Jason
next prev parent reply other threads:[~2022-04-20 15:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-18 17:41 [PATCH for-next v2] RDMA/rxe: Fix "Replace mr by rkey in responder resources" Bob Pearson
2022-04-19 16:18 ` Jason Gunthorpe
2022-04-19 22:02 ` Pearson, Robert B
2022-04-20 15:53 ` Jason Gunthorpe [this message]
2022-04-20 16:06 ` Pearson, Robert B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220420155312.GA1432137@nvidia.com \
--to=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearsonhpe@gmail.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox