Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
To: leonro@nvidia.com, jgg@nvidia.com
Cc: linux-rdma@vger.kernel.org
Subject: [PATCH for-next 4/6] RDMA/hfi1: Remove pointless driver version
Date: Fri, 20 May 2022 14:37:17 -0400	[thread overview]
Message-ID: <20220520183717.48973.17418.stgit@awfm-01.cornelisnetworks.com> (raw)
In-Reply-To: <20220520183516.48973.565.stgit@awfm-01.cornelisnetworks.com>

Driver versions have long been forbidden in the RDMA subsystem. We removed most
of the code relating to them and have been very strict about not allowing.
However there is some leftover versioning that we do not need. Get rid of that.

Signed-off-by: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
---
 drivers/infiniband/hw/hfi1/common.h |   15 ---------------
 drivers/infiniband/hw/hfi1/driver.c |    6 ------
 2 files changed, 21 deletions(-)

diff --git a/drivers/infiniband/hw/hfi1/common.h b/drivers/infiniband/hw/hfi1/common.h
index 995991d..73a2f13 100644
--- a/drivers/infiniband/hw/hfi1/common.h
+++ b/drivers/infiniband/hw/hfi1/common.h
@@ -155,21 +155,6 @@
 #define HFI1_KERN_SWVERSION ((HFI1_KERN_TYPE << 31) | HFI1_USER_SWVERSION)
 
 /*
- * Define the driver version number.  This is something that refers only
- * to the driver itself, not the software interfaces it supports.
- */
-#ifndef HFI1_DRIVER_VERSION_BASE
-#define HFI1_DRIVER_VERSION_BASE "0.9-294"
-#endif
-
-/* create the final driver version string */
-#ifdef HFI1_IDSTR
-#define HFI1_DRIVER_VERSION HFI1_DRIVER_VERSION_BASE " " HFI1_IDSTR
-#else
-#define HFI1_DRIVER_VERSION HFI1_DRIVER_VERSION_BASE
-#endif
-
-/*
  * Diagnostics can send a packet by writing the following
  * struct to the diag packet special file.
  *
diff --git a/drivers/infiniband/hw/hfi1/driver.c b/drivers/infiniband/hw/hfi1/driver.c
index e2c634a..8e71bef 100644
--- a/drivers/infiniband/hw/hfi1/driver.c
+++ b/drivers/infiniband/hw/hfi1/driver.c
@@ -29,12 +29,6 @@
 #undef pr_fmt
 #define pr_fmt(fmt) DRIVER_NAME ": " fmt
 
-/*
- * The size has to be longer than this string, so we can append
- * board/chip information to it in the initialization code.
- */
-const char ib_hfi1_version[] = HFI1_DRIVER_VERSION "\n";
-
 DEFINE_MUTEX(hfi1_mutex);	/* general driver use */
 
 unsigned int hfi1_max_mtu = HFI1_DEFAULT_MAX_MTU;


  parent reply	other threads:[~2022-05-20 18:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-20 18:36 [PATCH for-next 0/6] Updates for 5.19 Dennis Dalessandro
2022-05-20 18:37 ` [PATCH for-next 1/6] RDMA/hfi1: Prevent use of lock before it is initialized Dennis Dalessandro
2022-05-20 18:37 ` [PATCH for-next 2/6] RDMA/hfi1: Prevent panic when SDMA is disabled Dennis Dalessandro
2022-05-20 18:37 ` [PATCH for-next 3/6] RDMA/hfi1: Fix potential integer multiplication overflow errors Dennis Dalessandro
2022-05-20 18:37 ` Dennis Dalessandro [this message]
2022-05-20 18:37 ` [PATCH for-next 5/6] RDMA/hfi1: Consolidate software versions Dennis Dalessandro
2022-05-20 18:37 ` [PATCH for-next 6/6] RDMA/hfi1: Remove all traces of diagpkt support Dennis Dalessandro
2022-05-24 18:43 ` [PATCH for-next 0/6] Updates for 5.19 Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220520183717.48973.17418.stgit@awfm-01.cornelisnetworks.com \
    --to=dennis.dalessandro@cornelisnetworks.com \
    --cc=jgg@nvidia.com \
    --cc=leonro@nvidia.com \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox