From: Saeed Mahameed <saeed@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH (mellanox tree)] net/mlx5: delete dead code in mlx5_esw_unlock()
Date: Tue, 31 May 2022 13:11:25 -0700 [thread overview]
Message-ID: <20220531201125.46ecnnnzrqsqtejr@sx1> (raw)
In-Reply-To: <YpStOhUL4j7KBSqt@kili>
On 30 May 14:40, Dan Carpenter wrote:
You can use [PATCH net-mlx5] for fixes and [PATCH net-next-mlx5] for
none-critical commits.
>Smatch complains about this function:
>
> drivers/net/ethernet/mellanox/mlx5/core/eswitch.c:2000 mlx5_esw_unlock()
> warn: inconsistent returns '&esw->mode_lock'.
>
>Before commit ec2fa47d7b98 ("net/mlx5: Lag, use lag lock") there
>used to be a matching mlx5_esw_lock() function and the lock and
>unlock functions were symmetric. But now we take the long
^ lock ?
>unconditionally and must unlock unconditionally as well.
>
>As near as I can tell this is dead code and can just be deleted.
>
>Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixed up the typo and applied to net-next-mlx5.
Thanks,
Saeed.
next prev parent reply other threads:[~2022-05-31 20:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-30 11:40 [PATCH (mellanox tree)] net/mlx5: delete dead code in mlx5_esw_unlock() Dan Carpenter
2022-05-31 20:11 ` Saeed Mahameed [this message]
2022-06-01 6:52 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220531201125.46ecnnnzrqsqtejr@sx1 \
--to=saeed@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox