From: Jason Gunthorpe <jgg@nvidia.com>
To: Haris Iqbal <haris.iqbal@ionos.com>
Cc: yanjun.zhu@linux.dev, zyjzyj2000@gmail.com, leon@kernel.org,
linux-rdma@vger.kernel.org,
syzbot+833061116fa28df97f3b@syzkaller.appspotmail.com
Subject: Re: [PATCH 1/1] RDMA/rxe: Fix qp error handler
Date: Mon, 4 Jul 2022 10:06:23 -0300 [thread overview]
Message-ID: <20220704130623.GA1410451@nvidia.com> (raw)
In-Reply-To: <CAJpMwyhLuygVe3dsg=QkOWwmDSFxpRRjCWNAPr_YknPjub9WNg@mail.gmail.com>
On Wed, May 25, 2022 at 02:29:06PM +0200, Haris Iqbal wrote:
> > diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c b/drivers/infiniband/sw/rxe/rxe_verbs.c
> > index 9d995854a174..d0bc195b572f 100644
> > --- a/drivers/infiniband/sw/rxe/rxe_verbs.c
> > +++ b/drivers/infiniband/sw/rxe/rxe_verbs.c
> > @@ -432,7 +432,6 @@ static int rxe_create_qp(struct ib_qp *ibqp, struct ib_qp_init_attr *init,
> > return 0;
> >
> > qp_init:
> > - rxe_put(qp);
>
> Does this mean that in case rxe_qp_init_resp fails (rxe_qp_init_req
> had succeeded), we will NOT end up calling rxe_qp_do_cleanup? If so,
> would we miss shutting down and releasing qp->sk?
Zhu??
Jason
next prev parent reply other threads:[~2022-07-04 13:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 2:54 [PATCH 1/1] RDMA/rxe: Fix qp error handler yanjun.zhu
2022-05-25 12:29 ` Haris Iqbal
2022-07-04 13:06 ` Jason Gunthorpe [this message]
2022-07-04 14:18 ` Yanjun Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220704130623.GA1410451@nvidia.com \
--to=jgg@nvidia.com \
--cc=haris.iqbal@ionos.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=syzbot+833061116fa28df97f3b@syzkaller.appspotmail.com \
--cc=yanjun.zhu@linux.dev \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox