From: Saeed Mahameed <saeedm@nvidia.com>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
liorna@nvidia.com, raeds@nvidia.com, davem@davemloft.net
Subject: Re: [PATCH -next v2 1/2] net/mlx5e: add missing error code in error path
Date: Wed, 14 Sep 2022 21:10:28 +0100 [thread overview]
Message-ID: <20220914201028.5e7uhpmiolls2aw4@sx1> (raw)
In-Reply-To: <20220914140100.3795545-1-yangyingliang@huawei.com>
On 14 Sep 22:00, Yang Yingliang wrote:
>Add missing error code when mlx5e_macsec_fs_add_rule() or
>mlx5e_macsec_fs_init() fails. mlx5e_macsec_fs_init() don't
>return ERR_PTR(), so replace IS_ERR_OR_NULL() check with
>NULL pointer check.
>
>Fixes: e467b283ffd5 ("net/mlx5e: Add MACsec TX steering rules")
>Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
>---
>v2:
> Replace IS_ERR_OR_NULL() check with NULL pointer check.
>---
Acked-by: Saeed Mahameed <saeedm@nvidia.com>
netdev maintainers please apply directly.
Thanks.
next prev parent reply other threads:[~2022-09-14 20:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 14:00 [PATCH -next v2 1/2] net/mlx5e: add missing error code in error path Yang Yingliang
2022-09-14 14:01 ` [PATCH -next v2 2/2] net/mlx5e: Switch to kmemdup() when allocate dev_addr Yang Yingliang
2022-09-14 20:10 ` Saeed Mahameed
2022-09-14 20:10 ` Saeed Mahameed [this message]
2022-09-20 1:10 ` [PATCH -next v2 1/2] net/mlx5e: add missing error code in error path patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220914201028.5e7uhpmiolls2aw4@sx1 \
--to=saeedm@nvidia.com \
--cc=davem@davemloft.net \
--cc=linux-rdma@vger.kernel.org \
--cc=liorna@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=raeds@nvidia.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox