Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Zhu Yanjun <yanjun.zhu@intel.com>
To: leon@kernel.org, jgg@ziepe.ca, linux-rdma@vger.kernel.org,
	yanjun.zhu@linux.dev, yanjun.zhu@intel.com
Subject: [PATCH 1/1] RDMA/mlx5: Make mlx5 device work with ib_device_get_by_netdev
Date: Sun, 16 Oct 2022 02:19:25 -0400	[thread overview]
Message-ID: <20221016061925.1831180-1-yanjun.zhu@intel.com> (raw)

From: Zhu Yanjun <yanjun.zhu@linux.dev>

Before mlx5 ib device is registered, the function ib_device_set_netdev
is not called to map the mlx5 ib device with the related net device.

As such, when the function ib_device_get_by_netdev is called to get ib
device, NULL is returned.

Other ib devices, such as irdma, rxe and so on, the function
ib_device_get_by_netdev can get ib device from the related net device.

Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
---
 drivers/infiniband/hw/mlx5/main.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
index 883d7c60143e..6899c3f73509 100644
--- a/drivers/infiniband/hw/mlx5/main.c
+++ b/drivers/infiniband/hw/mlx5/main.c
@@ -168,6 +168,7 @@ static int mlx5_netdev_event(struct notifier_block *this,
 	u32 port_num = roce->native_port_num;
 	struct mlx5_core_dev *mdev;
 	struct mlx5_ib_dev *ibdev;
+	int ret = 0;
 
 	ibdev = roce->dev;
 	mdev = mlx5_ib_get_native_port_mdev(ibdev, port_num, NULL);
@@ -183,6 +184,14 @@ static int mlx5_netdev_event(struct notifier_block *this,
 		if (ndev->dev.parent == mdev->device)
 			roce->netdev = ndev;
 		write_unlock(&roce->netdev_lock);
+		if (ndev->dev.parent == mdev->device) {
+			ret = ib_device_set_netdev(&ibdev->ib_dev, ndev, port_num);
+			if (ret) {
+				pr_warn("func: %s, error: %d\n", __func__, ret);
+				goto done;
+			}
+		}
+
 		break;
 
 	case NETDEV_UNREGISTER:
@@ -191,6 +200,15 @@ static int mlx5_netdev_event(struct notifier_block *this,
 		if (roce->netdev == ndev)
 			roce->netdev = NULL;
 		write_unlock(&roce->netdev_lock);
+
+		if (roce->netdev == ndev) {
+			ret = ib_device_set_netdev(&ibdev->ib_dev, NULL, port_num);
+			if (ret) {
+				pr_warn("func: %s, error: %d\n", __func__, ret);
+				goto done;
+			}
+		}
+
 		break;
 
 	case NETDEV_CHANGE:
-- 
2.27.0


             reply	other threads:[~2022-10-15 13:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-16  6:19 Zhu Yanjun [this message]
2022-10-18  8:24 ` [PATCH 1/1] RDMA/mlx5: Make mlx5 device work with ib_device_get_by_netdev Leon Romanovsky
2022-10-18 14:19   ` Jason Gunthorpe
2022-10-19  8:56   ` yanjun.zhu
2022-10-19  9:08   ` yanjun.zhu
2022-10-19 11:55     ` Jason Gunthorpe
2022-10-19 14:30       ` Yanjun Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221016061925.1831180-1-yanjun.zhu@intel.com \
    --to=yanjun.zhu@intel.com \
    --cc=jgg@ziepe.ca \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=yanjun.zhu@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox