From: Md Haris Iqbal <haris.phnx@gmail.com>
To: linux-rdma@vger.kernel.org
Cc: leon@kernel.org, jgg@ziepe.ca, haris.iqbal@ionos.com,
Md Haris Iqbal <haris.phnx@gmail.com>
Subject: [PATCH for-next] RDMA/rxe: rxe_get_av always receives ahp hence no put is needed
Date: Thu, 20 Oct 2022 17:13:45 +0200 [thread overview]
Message-ID: <20221020151345.412731-1-haris.phnx@gmail.com> (raw)
The function rxe_get_av is only used by rxe_requester, and the ahp double
pointer is always sent. Hence there is no need to do the check.
rxe_requester also always performs the put for ah, hence that is also not
needed.
Signed-off-by: Md Haris Iqbal <haris.phnx@gmail.com>
---
drivers/infiniband/sw/rxe/rxe_av.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/infiniband/sw/rxe/rxe_av.c b/drivers/infiniband/sw/rxe/rxe_av.c
index 3b05314ca739..0780ffcf24a6 100644
--- a/drivers/infiniband/sw/rxe/rxe_av.c
+++ b/drivers/infiniband/sw/rxe/rxe_av.c
@@ -130,11 +130,7 @@ struct rxe_av *rxe_get_av(struct rxe_pkt_info *pkt, struct rxe_ah **ahp)
rxe_put(ah);
return NULL;
}
-
- if (ahp)
- *ahp = ah;
- else
- rxe_put(ah);
+ *ahp = ah;
return &ah->av;
}
--
2.25.1
next reply other threads:[~2022-10-20 15:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 15:13 Md Haris Iqbal [this message]
2022-10-21 5:58 ` [PATCH for-next] RDMA/rxe: rxe_get_av always receives ahp hence no put is needed Bob Pearson
2022-10-26 9:37 ` [kbuild] " Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221020151345.412731-1-haris.phnx@gmail.com \
--to=haris.phnx@gmail.com \
--cc=haris.iqbal@ionos.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox