Re: [PATCH 0/3] RDMA net namespace

Leon Romanovsky
2022-10-23T16:46:11Z

On Sun, Oct 23, 2022 at 09:42:00PM +0800, Yanjun Zhu wrote:
>
> 在 2022/10/23 21:04, Leon Romanovsky 写道:
> > On Sun, Oct 23, 2022 at 06:04:47PM -0400, Zhu Yanjun wrote:
> > > From: Zhu Yanjun <yanjun.zhu@linux.dev>
> > >
> > > There are shared and exclusive modes in RDMA net namespace. After
> > > discussion with Leon, the above modes are compatible with legacy IB
> > > device.
> > >
> > > To the RoCE and iWARP devices, the ib devices should be in the same net
> > > namespace with the related net devices regardless of in shared or
> > > exclusive mode.
> > >
> > > In the first commit, when the net devices are moved to a new net
> > > namespace, the related ib devices are also moved to the same net
> > > namespace.
> > I think that rdma_dev_net_ops are supposed to handle this.
>
> Yes. rdma_dev_net_ops can move ib devices from one net to another net.
>
> But these functions are called by a netlink command "rdma dev...".

rdma_dev_net_ops are called when you move netdevice from one netlink to
another.

However you raised an interesting question if it is correct behaviour to
move IB device after moved netdevice.

I don't know an answer for that.

Thanks